sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity
5,315 Commits 12 Branches 0 Tags 8.9 MiB
Commit Graph

5315 Commits

Author SHA1 Message Date
Caiwen Zhang 37d04bee15 gatppp: fix ppp protocol-reject constructing error 
In PPP Protocol-Reject package the 'rejected data field' should be a copy
of the rejected package, the copy starts from the data field. besides,
Protocol-Reject package include a 'rejected protocol field', it is the
same as the protocol field of the rejected package.

Protocol-Reject package structure is:

	| PPP_header | rejected protocol | rejected data

The rejected package structure is:
	| Addr | Control | protocol | data

So the Protocol-Reject package data field is copied from the 3rd byte of
the rejected package.
 2011-05-11 13:29:30 -05:00
Denis Kenzior 652f2963ae simfs: Fix error reported by valgrind 
==20365== Invalid read of size 8
==20365==    at 0x4B3501: sim_fs_free (simfs.c:114)
==20365==    by 0x493CEC: sim_remove (sim.c:2485)
==20365==    by 0x4703D7: modem_change_state (modem.c:410)
==20365==    by 0x470664: set_powered (modem.c:848)
==20365==    by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20365==    by 0x46F2C5: signal_cb (main.c:76)
==20365==    by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20365==    by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
==20365==    by 0x52A203B: g_main_context_dispatch (gmain.c:3013)
==20365==    by 0x52A2501: g_main_context_iterate (gmain.c:3091)
==20365==    by 0x52A2C98: g_main_loop_run (gmain.c:3299)
==20365==    by 0x46F0D3: main (main.c:243)
==20365==  Address 0x63ff998 is 8 bytes inside a block of size 16 free'd
==20365==    at 0x4C2612D: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20365==    by 0x52AA4A1: g_free (gmem.c:263)
==20365==    by 0x52C433D: g_slice_free1 (gslice.c:907)
==20365==    by 0x52C58D0: g_slist_free_1 (gslist.c:192)
==20365==    by 0x52C5C5F: g_slist_remove (gslist.c:465)
==20365==    by 0x4B342A: sim_fs_context_free (simfs.c:192)
==20365==    by 0x4B3500: sim_fs_free (simfs.c:117)
==20365==    by 0x493CEC: sim_remove (sim.c:2485)
==20365==    by 0x4703D7: modem_change_state (modem.c:410)
==20365==    by 0x470664: set_powered (modem.c:848)
==20365==    by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20365==    by 0x46F2C5: signal_cb (main.c:76)
 2011-05-11 12:29:59 -05:00
Denis Kenzior 993acd4132 simfs: Fix issue reported by valgrind 
==20287== Invalid read of size 4
==20287==    at 0x52B5C6B: g_queue_peek_nth_link (gqueue.c:704)
==20287==    by 0x52B5F57: g_queue_peek_nth (gqueue.c:848)
==20287==    by 0x4B33ED: sim_fs_context_free (simfs.c:170)
==20287==    by 0x4B34F8: sim_fs_free (simfs.c:116)
==20287==    by 0x493CEC: sim_remove (sim.c:2485)
==20287==    by 0x4703D7: modem_change_state (modem.c:410)
==20287==    by 0x470664: set_powered (modem.c:848)
==20287==    by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20287==    by 0x46F2C5: signal_cb (main.c:76)
==20287==    by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20287==    by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
==20287==    by 0x52A203B: g_main_context_dispatch (gmain.c:3013)
==20287==  Address 0x63fae70 is 16 bytes inside a block of size 24
free'd
==20287==    at 0x4C2612D: free (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20287==    by 0x52AA4A1: g_free (gmem.c:263)
==20287==    by 0x52C433D: g_slice_free1 (gslice.c:907)
==20287==    by 0x52B4E96: g_queue_free (gqueue.c:60)
==20287==    by 0x4B34E0: sim_fs_free (simfs.c:107)
==20287==    by 0x493CEC: sim_remove (sim.c:2485)
==20287==    by 0x4703D7: modem_change_state (modem.c:410)
==20287==    by 0x470664: set_powered (modem.c:848)
==20287==    by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
==20287==    by 0x46F2C5: signal_cb (main.c:76)
==20287==    by 0x52F555E: g_io_unix_dispatch (giounix.c:166)
==20287==    by 0x52A0AAB: g_main_dispatch (gmain.c:2440)
 2011-05-11 12:20:59 -05:00
Denis Kenzior 4714d8199a gprs: Mark context inactive on removal 2011-05-11 12:11:23 -05:00
Denis Kenzior 623183d996 gprs: Fix valgrind error 
This fixes an invalid access condition for the case where the
gprs atom is destroyed before context atoms are.
 2011-05-11 12:11:23 -05:00
Denis Kenzior de0b882acf gprs: emit Active changed for contexts being removed 2011-05-11 12:11:23 -05:00
Denis Kenzior 5646ecaf35 gprs: Add additional debug statements 2011-05-11 12:11:23 -05:00
Denis Kenzior 9c8451a1b8 phonesim: Create atoms in a different order 
This uncovers a valgrind condition:

==17231== Invalid read of size 8
==17231==    at 0x4A2461: gprs_context_unregister (gprs.c:2143)
==17231==    by 0x46FEB0: __ofono_atom_unregister (modem.c:260)
==17231==    by 0x4703C9: modem_change_state (modem.c:407)
==17231==    by 0x470664: set_powered (modem.c:848)
==17231==    by 0x4706BA: __ofono_modem_shutdown (modem.c:2137)
 2011-05-11 12:11:19 -05:00
Philippe Nunes 563fcc5fe9 stkutil: Send at least the data currently available 2011-05-08 23:30:10 -05:00
Denis Kenzior b1f4e981f4 sim: Fix potential use of uninitialized variable 
In certain circumstances, when the image has been cached but EFimg has
not been read yet, we might end up accessing an unitialized variable.
Fix this by always failing if EFimg has not been read yet.
 2011-05-08 23:27:17 -05:00
Frédéric Danis 33515dbab3 emulator: add AT+CMEE support for HFP 2011-05-08 23:21:41 -05:00
Guillaume Zajac 762dba6bc3 emulator: add dun_ath_cb() and register it 2011-05-08 23:18:19 -05:00
Guillaume Zajac daf7c57178 emulator: add handler for ppp stream suspensions 
Resulting from the client sending '+++' escape sequence.
 2011-05-08 23:14:05 -05:00
Guillaume Zajac f1cbb783fc gatppp: Add API for setting suspend callback 
In situations where the PPP stream can be suspended by the peer, e.g. in
the server role using '+++'
 2011-05-08 23:03:22 -05:00
Denis Kenzior d48c309151 ppp_net: Reset the watch to zero when removing 2011-05-08 23:02:19 -05:00
Guillaume Zajac 9fea153593 ppp_net: add ppp_net_suspend_interface() function 2011-05-08 23:00:12 -05:00
Guillaume Zajac badd5555ec gathdlc: delete read/write handler in hdlc_suspend 2011-05-08 22:59:03 -05:00
Guillaume Zajac 8a56acd549 gathdlc: Add public suspend function 2011-05-08 22:58:41 -05:00
Marcel Holtmann 6d426a19a6 gatchat: Fix memory leak with notify nodes list 
The list itself needs to be freed as well and not only its elements.
 2011-05-06 09:19:54 -07:00
Bertrand Aygon f35f985235 call-forwarding: Fix uninitialized var warning 
Fix a gcc 4.5.2 warning uninit var
 2011-05-05 21:18:39 -05:00
Denis Kenzior 5c9d59bad1 voicecall: CHLD support must be enclosed in a list 2011-05-04 22:29:08 -05:00
Denis Kenzior 2a5f5fe6be voicecall: Simplify CHLD support generator 
In addition, fix ordering and make sure that lower case 'x' is used
 2011-05-04 22:27:03 -05:00
Denis Kenzior 1655cb9bd2 voicecall: CHLD call ids start at 1, not 0 2011-05-04 22:03:11 -05:00
Frédéric Dalleau 307687942a voicecall: add +CHLD=2X support for HFP emulator 2011-05-04 22:00:21 -05:00
Frédéric Dalleau aa0f93b664 voicecall: add +CHLD=1X support for HFP emulator 2011-05-04 22:00:07 -05:00
Frédéric Dalleau 6d501aa93a voicecall: add +CHLD=4 support for HFP emulator 2011-05-04 21:59:21 -05:00
Frédéric Dalleau bb02dd4070 voicecall: add +CHLD=3 support for HFP emulator 2011-05-04 21:59:18 -05:00
Frédéric Dalleau 81ccae5a97 voicecall: add +CHLD=0 support for HFP emulator 2011-05-04 21:58:23 -05:00
Frédéric Dalleau 41d54b2718 voicecall: add +CHLD support for HFP emulator 2011-05-04 21:57:30 -05:00
Frédéric Dalleau ffe11200a9 voicecall: Fix variable initialization 2011-05-04 21:51:27 -05:00
Denis Kenzior dc86e86446 gathdlc: Make sure to set in_read_handler properly 2011-05-02 07:15:41 -05:00
Denis Kenzior 94d6d505ee gathdlc: Add support for detecting +++ escapes 2011-05-02 07:06:28 -05:00
Guillaume Zajac 70ae2f0028 gatio: add ability to drain GAtIO read buffer 2011-05-02 07:05:57 -05:00
Guillaume Zajac 6b3cfbba85 gat: add GAtSuspendFunc CB typedef 2011-04-29 08:30:22 -05:00
Bertrand Aygon 48e97447ab sms: Remove use of uninitialized variable 
Remove a debug information, since the info is useless, and more,
it can display invalid info due to var not initialise in some case
 2011-04-29 04:15:47 -05:00
Denis Kenzior 2f2436bc20 modem: Don't allow setting online unless powered 2011-04-28 09:48:48 -05:00
Denis Kenzior 407e177bc1 test: Add swap-calls test script 2011-04-28 09:30:54 -05:00
Pekka Pessi 847a09dc47 gisi: log normal responses in a less confusing way 2011-04-28 09:29:26 -05:00
Denis Kenzior 082c098b2a build: Add send-vcal to Makefile.am 2011-04-28 09:20:11 -05:00
Bertrand Aygon b5acc93aec test: Add send-vcal test script 2011-04-28 09:20:11 -05:00
Bertrand Aygon fa552ed8c4 test: Add modem argument to send-vcard 2011-04-28 09:20:11 -05:00
Bertrand Aygon aedd02a1fe test: Add modem argument to send-sms 2011-04-28 09:20:11 -05:00
Marcel Holtmann d6fc5ffd5b Release 0.48 2011-04-26 13:29:19 -07:00
Martin Xu eaf6f64879 huawei: Switch to offline mode only if offline 2011-04-26 14:55:55 -05:00
Martin Xu d38fa75518 huawei: Check that the modem device is open 
Don't create the gprs atom if the modem device was not opened
successfully.  Otherwise ofonod will crash.
 2011-04-26 14:51:57 -05:00
Martin Xu 0dc3d69c54 gatppp: Fix crash related to not stopping timers 
In case of offline modem when GPRS data connection is connected, if gprs
atom is removed before PPP termination process is complete, the terminate_timer
will not be stop. It will cause ofonod crash when the timer times out.
 2011-04-26 14:47:11 -05:00
Frédéric Danis b60762e026 voicecall: fix waiting calls for HFP emulator 
Fix precedence between waiting and dialing so HFP emulator is notified
of dialing/alerting even in case of a waiting call pending.
 2011-04-26 14:43:42 -05:00
Denis Kenzior f8eb178b29 voicecall: Update CLCC buffer size and comment 2011-04-26 14:41:52 -05:00
Denis Kenzior 97a7a61789 voicecall: Refactor the previous commit slightly 2011-04-26 14:41:26 -05:00
Frédéric Dalleau 719fae9587 voicecall: add +CLCC support for HFP emulator 2011-04-26 14:22:11 -05:00