Commit Graph

2479 Commits

Author SHA1 Message Date
Denis Kenzior 7eda56a6b4 stkutil: Various code style issues 2010-05-25 16:52:52 -05:00
Andrzej Zaborowski 355b038c6f test-stkutil: Add Get Inkey response tests 2010-05-25 16:52:52 -05:00
Andrzej Zaborowski eacb4395fc stkutil: Add Get Inkey response builder 2010-05-25 16:52:52 -05:00
Denis Kenzior 60cab4354c stkutil: Make the code more readable 2010-05-25 16:52:52 -05:00
Andrzej Zaborowski 4dcce0304a test-stkutil: Add Display Text response tests 2010-05-25 16:52:52 -05:00
Andrzej Zaborowski 5953762a7b stkutil: Add Display Text response builder 2010-05-25 16:52:52 -05:00
Denis Kenzior 706c5aa994 stkutil: Simplify append_text 2010-05-25 16:52:51 -05:00
Andrzej Zaborowski 6831adfa74 Add STK-specific CTLV encoding utilities 2010-05-25 16:52:51 -05:00
Denis Kenzior 83240f1389 simutil: simplify ctlv logic 2010-05-25 16:52:51 -05:00
Denis Kenzior ec8a6cbc43 simutil: Simplify ber_tlv_builder_optimize logic 2010-05-25 16:52:51 -05:00
Denis Kenzior ea46bae631 simutil: Simplify ber_tlv builder set_length logic 2010-05-25 16:52:51 -05:00
Denis Kenzior fd8d7b8992 simutil: Simplify builder_write_header 2010-05-25 16:52:51 -05:00
Denis Kenzior 91c4644458 simutil: Be more type-correct 2010-05-25 16:52:51 -05:00
Denis Kenzior afedfcb486 simutil: Get rid of ugly-named functions
Replace them by macros
2010-05-25 16:52:51 -05:00
Andrzej Zaborowski dcc23e30fe test-simutil: Add a BER-TLV encoding tests 2010-05-25 16:52:51 -05:00
Andrzej Zaborowski 1c3060026e simutil: Add utilities for encoding BTLV and CTLV 2010-05-25 16:52:50 -05:00
Pessi Pekka (Nokia-D/Helsinki) 0318e194b3 isimodem: fix confusing log message 2010-05-26 00:07:30 +03:00
Pessi Pekka (Nokia-D/Helsinki) 9ec222fc94 isimodem: fix memory leak 2010-05-26 00:07:05 +03:00
Pessi Pekka (Nokia-D/Helsinki) 647a2e56b9 Fix: set correct local address for phonet on PCs 2010-05-26 00:06:43 +03:00
Aki Niemi e1d5f09eb9 Fix minor style issues 2010-05-26 00:06:12 +03:00
Pessi Pekka (Nokia-D/Helsinki) abb642ce08 Add: support for EF_ICCID in isimodem. 2010-05-26 00:00:13 +03:00
Kalle Valo 53d70bc137 huawei: remove voicecall support
These modems don't support voicecall anyway. Recommended by Denis.
2010-05-25 09:47:18 -05:00
Kalle Valo 99e4200c64 huawei: send a prefix with AT commands 2010-05-25 09:47:03 -05:00
Kalle Valo 2d3c0cd3b0 huawei: properly notify sim state to ofono
Instead of using ofono_modem_set_powered(), use ofono_sim_inserted_notify()
which is the proper way to notify about sim state changes.

Now the problem is that voicecall commands fail with my Huawei E1552:

ofonod[12395]: > AT+CRC=1\r
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CLIP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+COLP=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: > AT+CCWA=1\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n
ofonod[12395]: drivers/atmodem/voicecall.c:at_voicecall_initialized()
  voicecall_init: registering to notifications
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
ofonod[12395]: > AT^SYSINFO\r
ofonod[12395]: < \r\n^SYSINFO:0,0,0,0,255,,0\r\n\r\nOK\r\n
ofonod[12395]: > AT+CGMI\r
ofonod[12395]: < \r\nhuawei\r\n\r\nOK\r\n
ofonod[12395]: EventChannel: < \r\n^STIN:0,0,0\r\n
ofonod[12395]: > AT+CLCC\r
ofonod[12395]: < \r\n+CME ERROR: SIM busy\r\n

But as I can't make voice calls with this modem anyway, I don't worry
about them right now.
2010-05-25 09:46:37 -05:00
Kalle Valo 3cdbed3c37 huawei: use g_at_result_iter_skip_next() 2010-05-25 09:45:18 -05:00
Marcel Holtmann 1ff130d66e Some minor cleanups for the Huawei plugin 2010-05-25 11:13:48 +02:00
Kalle Valo 160e4fe122 huawei: follow sim state change notifications
With Huawei E1552 I got sim busy errors when I plugged in the modem
and ofono was already running:

May 24 17:02:04 tukki ofonod[7619]: > AT+CRC=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
May 24 17:02:04 tukki ofonod[7619]: > AT+CLIP=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n

Fix this by following sim state changes with ^SIMST notification and
only enable modem after SIM is ready. In case SIM is already ready
and we miss the notification for some reason, also use AT^SYSINFO
to check the state during enable phase.

Also change huawei_enable() to return -EINPROGRESS to make sure that
ofono modem is not powered too early. I believe this was a bug.
2010-05-25 11:11:11 +02:00
Marcel Holtmann 6322542719 Break function declaration down to two lines 2010-05-25 11:08:58 +02:00
Gustavo F. Padovan d62548bfd0 Bring back -d option without need for argument 2010-05-25 11:08:22 +02:00
Marcel Holtmann 1ec9c6c3b6 Some extra empty lines to separate chapters 2010-05-21 11:43:30 +02:00
Denis Kenzior 73bfae4f46 sim: Read EFiccid after EFphase 2010-05-19 23:48:34 -05:00
Denis Kenzior bbd6a1d48a sim: No need for this define 2010-05-19 23:47:41 -05:00
Daniel Wagner b338033307 Read EF_ICCID property of SIM
Tested with phonesim.
2010-05-19 23:41:03 -05:00
Denis Kenzior 96480e44b2 netreg: Fix crash when CREG is reported too early
If we register for CREG notifications before the netreg atom is
registered (e.g. in MBM due to CIND queries) we crash if the CREG
notification arrives before the CIND is queried.
2010-05-19 23:33:17 -05:00
Kalle Valo 36e9803cdc huawei: add gprs context
Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
SIM.
2010-05-19 23:09:21 -05:00
Kalle Valo bf5b31e8a8 Move report_signal_strength to atutil
The function is needed in two different places, better to move it
to atutil.h.
2010-05-19 23:08:36 -05:00
Kalle Valo 6f4b3c31fd huawei: detect possible secondary device 2010-05-19 23:08:33 -05:00
Denis Kenzior 6b0f2328c5 Update TODO 2010-05-19 06:58:37 -05:00
Denis Kenzior 9fc185675b Update TODO 2010-05-19 06:49:24 -05:00
Denis Kenzior bcb075994e Update TODO 2010-05-19 06:37:56 -05:00
Denis Kenzior c48655652f Update TODO 2010-05-19 06:32:29 -05:00
Marcel Holtmann 8e4298f7fd Add some extra markups for TODO list 2010-05-19 14:58:04 +02:00
Denis Kenzior 83fc72c95a core: Trivial whitespace error 2010-05-19 05:26:35 -05:00
Denis Kenzior 1803f00c6e ppp: Trivial whitespace error 2010-05-19 05:26:21 -05:00
Denis Kenzior e7a590acfc Add initial TODO file 2010-05-19 05:25:06 -05:00
Kristen Carlson Accardi 3fff4c49c8 ppp: implement ppp_packet_new 2010-05-19 02:58:45 -05:00
Aki Niemi 0d8b86ed79 Add isimodem support for network time 2010-05-19 10:46:33 +03:00
Aki Niemi b8ec7553ef Add network time support
Adding a new notify function in the netreg atom for notifying a
received Network Identification and Timezone (NITZ) indication. This
data is consumed via a nettime plugin, of which there is also an
example.
2010-05-19 10:46:18 +03:00
Aki Niemi 1d7fe6aa5a gisi: Fix style issues 2010-05-17 14:28:39 +03:00
Pekka Pessi d44444562b Make isimodem use linkstate directly 2010-05-17 13:52:13 +03:00