Commit Graph

8553 Commits

Author SHA1 Message Date
Pavel Machek 89d1faca3b test: better help text for dial-number
Better help text for "dial-number". Without details, user may be
tempted to pass 0|1 (as send-sms uses) or true|false.
2019-02-02 09:26:15 -06:00
Nandini Rebello 55e5a766f2 modem: add support to clear cached pins.
If the modem is powered off via D-Bus, clear any cached PINs to make
sure that automatic PIN entry behavior is not activated.
2019-01-23 17:49:53 -06:00
Denis Kenzior 3152c59455 sim: Fix memory leaks introduced by sim pin caching 2019-01-23 17:49:49 -06:00
Nandini Rebello f36d6d05cc sim: Sim PIN1 cache upon modem reset/crash
Adding SIM PIN caching feature to oFono. oFono now caches the SIM PIN1
type against the ICCID throughout its lifetime in a link list and
enters implicitly upon modem reset/crash.

Note, that this behavior can violate 3GPP spec 21.111, section 5.3 -
User Data stored in ME if that section is interpreted very strictly.
However, our interpretation is that firmware resets are allowed, based
on historic precedent.  Helps in user experience by not barring out
cellular services unless pin is entered manually.

Handles cases of incorrect pin and sim pin changed externally.
Clear cached PIN incase modem disabled manually and selectively when
sim is removed.

Seperate 'pin_cache_enter_cb' added without dbus calls to handle
implict entering of cached pin.

For now this behavior is applicable to all modems by default.  In the
future it may be needed to make this behavior opt in or otherwise
configurable.
2019-01-23 17:44:31 -06:00
Marcel Holtmann 08821bba5b gitignore: unit/test-idmap binary 2019-01-23 19:15:50 +01:00
Marcel Holtmann 5e597b599c Release 1.28 2019-01-23 19:13:20 +01:00
Denis Kenzior dd72460bd1 AUTHORS: Mention Pavel's contributions 2019-01-22 11:03:07 -06:00
Pavel Machek cc3375e2dd rilmodem: fix compilation on gcc-6.3
gcc-6 fails to compile ofono due to #pragma directives. Limit them to
gcc versions where they are needed.
2019-01-22 11:02:30 -06:00
Denis Kenzior dbc314ebc4 stkutil: Fix ofono_bool_t usage
The actual datatype is bool
2019-01-18 08:55:52 -06:00
Marcel Holtmann 5b988c052f build: Use -fsigned-char and -fno-exceptions compiler options 2019-01-18 09:39:57 +01:00
Antara Borwankar 80470869e5 ifxmodem: removing TAP/TUN support check for XMM vendor
skipping TAP/TUN support check from gprs-context probe for
xmm vendor. xmm modem does not require TAP/TUN support. Also
it is not enabled by default in enbedded yocto bsp.
2019-01-15 14:54:52 -06:00
Denis Kenzior c3fdf6a7c5 gprs: Fix allocation of context id
After the convertion to l_uintset, the creation of new contexts fails
due to a range error being returned from l_uintset_find_unused().

The error happens because the uinset is created with a min-value of 1,
but the start-value passed to l_uintset_find_unused() is initialized as
0.

Reported-by: Martin Hundebøll <martin@geanix.com>
2019-01-03 17:17:21 -06:00
Denis Kenzior 7982635328 AUTHORS: Mention Khaled's contributions 2019-01-03 17:14:37 -06:00
Khaled Romdhani 4462bde1f2 gemalto: Move atoms to post_online
when the voice call driver is probing, I noticed sometimes
a CME Error with the code = 4 (operation not supported)
related to AT commands "AT+CSSN=1,1" and "AT^SLCC=1".

In the current voice call implementation for Gemalto modems
the ofono_voicecall_create() is called on the gemalto_pre_sim().
The sim is not totaly readed by the module, it is not yet
online which is causing a sporadic problem at driver
intialization also when launching some outgoing/incoming calls.

This change moves the ofono_voicecall_create() to the
gemalto_post_online() to be sure that sim is well registred
and online.  Several other call related atoms are also moved to
post_online state.
2019-01-03 17:13:58 -06:00
Denis Kenzior 9601ff5331 stkutil: Use standard types 2018-12-29 15:26:37 -06:00
Denis Kenzior 270d19495c rilmodem: Fix compiler error 2018-12-29 14:19:16 -06:00
Denis Kenzior e3585383be unit: Update to the new stkutil api 2018-12-29 14:15:04 -06:00
Denis Kenzior 27c9952f86 stkutil: Convert away from glib datatypes 2018-12-29 14:14:51 -06:00
Denis Kenzior c3d5ccbe53 stkutil: Use l_queue instead of GSList 2018-12-28 18:12:21 -06:00
Denis Kenzior 22002d142c stkutil: Use l_queue instead of GSList 2018-12-28 13:48:34 -06:00
Denis Kenzior 4927905db4 stkagent: Use bool instead of gboolean / ofono_bool_t 2018-12-28 13:47:41 -06:00
Denis Kenzior f13047bf93 stktest: Fix immediate response test
Commit f39d7efb53 changed the amount of
time an immediate response text is displayed.  Fix stktest accordingly.
2018-12-27 18:19:31 -06:00
Denis Kenzior 2b909e8371 stktest: Handle self-explanatory icons
At some point, self-explanatory icons meant that no text was sent to the
agent, yet stktest was never updated to reflect that behavior.  Update
this properly.
2018-12-27 18:18:51 -06:00
Denis Kenzior caeb1650a1 util: Remove last glib uses 2018-12-27 18:18:51 -06:00
Denis Kenzior 50077ee352 rilmodem: Use l_util_hexstring instead of encode_hex 2018-12-27 18:18:51 -06:00
Denis Kenzior 305ae9ba84 atmodem: Use l_util_hexstring instead of encode_hex 2018-12-27 18:18:51 -06:00
Denis Kenzior 5e1471d3eb unit: Use l_util_hexstring instead of encode_hex 2018-12-27 18:18:51 -06:00
Denis Kenzior 9d18385e5f util: Remove encode_hex 2018-12-27 18:18:51 -06:00
Denis Kenzior b2ebd60bcd rilmodem: Convert decode_hex to l_util_from_hexstring 2018-12-27 18:18:51 -06:00
Denis Kenzior 2984391b31 unit: Switch decode_hex to l_util_from_hexstring 2018-12-27 18:18:51 -06:00
Denis Kenzior d793b291b3 util: Remove decode_hex 2018-12-27 18:18:51 -06:00
Denis Kenzior f7d8edeaac stkutil: Convert stk_image_to_xpm to ell 2018-12-27 18:18:51 -06:00
Denis Kenzior 1d08969613 stkutil: Convert stk_text_to_html to use ell 2018-12-27 18:18:51 -06:00
Denis Kenzior 69f8cb53a6 build: Add string utilities from ell to build 2018-12-27 18:18:51 -06:00
Denis Kenzior b66abb4902 stkutil: Use l_malloc 2018-12-27 18:18:51 -06:00
Denis Kenzior a65bf69f38 drivers: update to use l_free
Previous commit changes character conversion functions to use ell memory
allocation routines.  Update all uses to free memory using the same.
2018-12-27 18:18:51 -06:00
Denis Kenzior 9396120cf9 unit: Update to use l_free instead of g_free
Previous commit changes character conversion functions to use ell memory
allocation routines.  Update all uses to free memory using the same.
2018-12-27 18:18:51 -06:00
Denis Kenzior 4059d4226b util: Switch character conversions to ell
Switch various conversions from GSM/UCS2 to UTF8 from glib based
implementation over to ell.

This also converts all related g_free calls to l_free calls (though in
the end they are equivalent calls to free)
2018-12-27 18:18:51 -06:00
Denis Kenzior 44415e754b smsutil: Use l_utf8_from_utf16 instead of g_convert 2018-12-27 18:18:51 -06:00
Denis Kenzior 77271f33d2 drivers: switch g_convert usage to ell 2018-12-27 18:18:51 -06:00
Denis Kenzior b99c15f8e2 unit: Fix memory leak 2018-12-27 18:18:51 -06:00
Denis Kenzior 9c7a87673a util: Use l_utf8_to_ucs2be instead of g_convert 2018-12-27 18:18:51 -06:00
Denis Kenzior 351088e185 unit: Convert to new convert_utf8_to_gsm API 2018-12-27 18:18:51 -06:00
Denis Kenzior 5229080d92 util: Use ell in convert_utf8_to_gsm 2018-12-27 18:18:51 -06:00
Denis Kenzior c4b073aa89 unit: Update to the new convert_ucs2_to_gsm API 2018-12-27 18:18:51 -06:00
Denis Kenzior 88ff5d36dd drivers: Update to new convert_ucs2_to_gsm API
Use l_free instead of g_free since the above API was changed to use ell
2018-12-27 18:18:51 -06:00
Denis Kenzior c4ed942e40 util: use ell in convert_ucs2_to_gsm_with_lang 2018-12-27 18:18:51 -06:00
Denis Kenzior 71544d7fe1 unit: convert usage of g_test_verbose
Convert all usages of this function in favor of using a static VERBOSE
variable.  We almost never use verbose output except while debugging.

Additionally this allows us to more easily convert all unit tests to the
ell unit test framework
2018-12-27 18:18:51 -06:00
Denis Kenzior 538804e191 unit: Update to the new pack_7bit/unpack_7bit api 2018-12-27 18:18:51 -06:00
Denis Kenzior d5f117be80 util: Convert pack7_bit / unpack_7bit to use l_malloc 2018-12-27 18:18:51 -06:00