Denis Kenzior
a8f15c5cf3
sim: Fixup compiler complaints
...
src/sim.c:2396: error: comparison between signed and unsigned integer
expressions
src/sim.c:2396: error: comparison between signed and unsigned integer
expressions
2011-02-08 10:19:52 -06:00
Jussi Kangas
a8671fe1f7
sim: Allow usage of SIM codes longer than 8 digits
...
Some PIN codes (e.g. subsidy locks, etc) can have PIN codes much longer
than the default 8 digits.
2011-02-08 10:19:52 -06:00
Denis Kenzior
53d8bbfe29
sim: Add implementation of sim file watching API
2011-02-07 12:26:50 -06:00
Andrzej Zaborowski
a7a0cb1ed0
simfs: implement ofono_sim_context api
2011-02-03 13:13:37 -06:00
Aki Niemi
a8112dc1ea
sim: Fix style issues
2011-02-02 11:03:21 +02:00
Marcel Holtmann
bd1e6a2a3a
sim: Remove double empty lines
2011-01-22 11:06:34 +01:00
Jukka Saunamaki
0ef557e766
sim: getters for mcc and mnc implementation
2011-01-20 11:04:00 -06:00
Jukka Saunamaki
da535d1288
sim: store mcc and mnc separate from imsi
2011-01-20 11:03:43 -06:00
Jeevaka Badrappan
2b8a358601
sim: fix issue with sizeof call
...
In some compilers, sizeof the functional argument is
not returning the actual sizeof the argument.
2011-01-17 17:05:26 +01:00
Denis Kenzior
a4675c50aa
sim: Minor style fixes
2011-01-10 15:42:24 -06:00
Lucas De Marchi
99dd118c5b
sim: query remaining pin retries
...
Check the remaining pin retries after each operation that might have
changed it, i.e. locking, unlocking, reseting or changing pin.
2011-01-10 15:38:59 -06:00
Andrzej Zaborowski
bb9e26f2a5
sim: Set sane number len in empty EFmsisdn records
...
Valid number length range is 1 - 11 bytes, other values, such as 0xff,
could potentially crash external parsers.
2010-12-21 14:25:09 -06:00
Jeevaka Badrappan
a8c94c044f
sim: fix minor issue in ofono_sim_get_phase
2010-12-12 04:37:52 -06:00
Jeevaka Badrappan
5154d5e38d
sim: be more paranoid for triggering EFest read
2010-11-29 14:57:04 -06:00
Lucas De Marchi
b210838e87
core: explicitly compare pointers to NULL
...
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/ )
// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@
- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Rémi Denis-Courmont
e7c4442c69
core: Remove stray newlines in messages sent to log
2010-11-26 13:50:15 -06:00
Jeevaka Badrappan
2d0cb92155
src: coding style fixes - rule M6
2010-11-22 05:07:52 -06:00
Andrzej Zaborowski
3083841f72
sim: Add sim_service_available()
...
This is meant to query EFsst or EFust.
The function is not public api because the service constants are in
src/simutil.h.
2010-11-10 09:09:05 -06:00
Denis Kenzior
d7403d521b
sim: Check both EFust and EFest for FDN & BDN
...
We were checking EFest only for whether BDN and FDN were enabled.
According to 31.102 Section 5.3.2 we should be checking both EFust
(availability of the service) and EFest (whether it is enabled)
2010-11-05 09:14:32 -05:00
Denis Kenzior
e613c686a6
sim: Don't read EFest if the file is not available
2010-11-05 09:14:32 -05:00
Guillaume Lucas
aa2c87886f
sim: use mask for check of sim file status
...
It is the first bit of the sim file status who indicates if a file
is valid or not. So a mask must be used to check this.
2010-11-05 09:14:32 -05:00
Denis Kenzior
dc43b56154
sim: Fix minor style issue
2010-10-25 10:39:09 -05:00
Jeevaka Badrappan
233bd42820
sim: add barred dialing support
2010-10-25 10:39:09 -05:00
Denis Kenzior
107a38de85
sim: Pass dbus types
...
Can't really assume they're the same as glib types
2010-10-22 11:58:59 -05:00
Denis Kenzior
8b40f6c1a0
sim: Get rid of unneeded empty line
2010-10-22 11:57:18 -05:00
Denis Kenzior
39a3080a4b
sim: Break out common FDN property signaling
2010-10-22 11:56:35 -05:00
Petteri Tikander
7de5e48df8
sim: check existence of imsi-code
...
For instance: when handling sim_get_properties
in PRE_SIM-state imsi is not received/stored.
2010-10-22 11:23:08 -05:00
Petteri Tikander
d82600c893
sim: check if Fixed Dial is enabled in SIM-card
...
If SIM-card is inserted, status is checked from EFsst
(is FDN activated) and EFadn (is ADN invalidated).
If USIM-card is inserted, status is checked from EFest
(is FDN activated).
If FD is enabled, halt SIM initialization procedure.
New property (FixedDialing) is added. If FD is enabled,
this has been signalled via DBUS.
2010-10-22 11:21:23 -05:00
Denis Kenzior
b92662634d
sim: Read EFust and EFest after phase is known
2010-10-19 14:20:57 -05:00
Denis Kenzior
04755acc3a
sim: Fix setting the correct phase from EFphase
2010-10-19 14:07:41 -05:00
Denis Kenzior
0564176a9c
sim: Fix crash on sim re-insertion
2010-10-15 06:26:34 -05:00
Denis Kenzior
a4d90fd4eb
sim: Refactor iidf reading
...
Get rid of image_data since it can lead to potential memory leaks when
sim is removed while the IIDF operations are in progress.
2010-10-13 08:41:41 -05:00
Denis Kenzior
ccf4b34522
sim: Use ay return signature for GetIcon
2010-10-13 05:04:47 -05:00
Denis Kenzior
56e0a7644f
simfs: Reflow to get rid of unnecessary label
2010-10-13 05:04:46 -05:00
Denis Kenzior
90f531768f
sim: Use g_dbus_create_reply
...
Instead of compound statements
2010-10-13 05:04:46 -05:00
Denis Kenzior
b750de3ec6
sim: Don't re-check for id != 0
...
We already check the id is valid in the get_icon function, there's no
reason to re-check it.
2010-10-13 05:04:46 -05:00
Kristen Carlson Accardi
42c29c795f
sim: implement GetIcon
2010-10-13 05:04:46 -05:00
Jeevaka Badrappan
4196182770
Fix multi-line comment style issues
2010-09-21 21:16:01 -05:00
Denis Kenzior
cd8df455e1
sim: Use sim_fs_check_version
2010-09-09 08:50:29 -05:00
Denis Kenzior
5754eaf7e9
sim: Break out sim file reading into simfs
2010-09-09 08:50:28 -05:00
Denis Kenzior
e3bd339e16
sim: Unify sim_read and sim_read_bytes
2010-09-09 08:50:28 -05:00
Kristen Carlson Accardi
95d957b62e
sim: read EFiidf
...
EFiidf can be larger than 256 bytes, so allow callers to read
portions of the EFiidf from a specified offset. Cache EFiidf
files as blocks of 256 bytes so that it's not necessary to
read the entire (potentially large) file.
2010-09-09 08:45:32 -05:00
Denis Kenzior
4b43650116
sim: cleanup sim atom private structure
...
The number of elements was getting out of hand and out of order
2010-09-01 12:06:59 -05:00
Denis Kenzior
0cf73b73eb
sim: tweak efimg length
2010-09-01 12:06:56 -05:00
Yang Gu
d43b2c0a61
sim: Read EFsst
2010-08-31 13:07:54 -05:00
Denis Kenzior
4292b2dbed
sim: Turn around the order of arguments
...
The void *user argument was first. It should be last instead to be
consistent with the other watch functions.
2010-08-30 14:29:34 -05:00
Kristen Carlson Accardi
d3eb346b40
sim: read EFimg
2010-08-26 18:40:12 -05:00
Denis Kenzior
74a88dda81
sim: Check PIN even if no EFli / EFpl not read
2010-08-25 10:00:09 -05:00
Denis Kenzior
687e171949
sim: Retrieve EFphase according to the spec
2010-08-23 14:29:22 -05:00
Denis Kenzior
38300af0da
sim: Reorder SIM initialization
2010-08-23 14:29:22 -05:00
Denis Kenzior
cbf783c334
sim: Reset mnc_length when removing SIM
...
In case the next SIM doesn't have it or something else weird happens.
2010-08-23 14:29:22 -05:00
Denis Kenzior
f78eaf94cf
sim: Update the SIM initialization comment
2010-08-23 14:29:22 -05:00
Denis Kenzior
fc70af8ea1
sim: Minor style fix
2010-08-23 14:29:21 -05:00
Yang Gu
c679babdc5
sim: Read EFust and EFest
2010-08-23 14:29:21 -05:00
Denis Kenzior
8eb9425f32
sim: Use less space for locked_pins
...
Use only as required, since we only track PINs in this one, not PUKs
2010-08-05 10:19:04 -05:00
Denis Kenzior
764afde1fe
sim: Fix LockedPins in case SIM wants a PUK first
...
In the case that oFono is started with the SIM asking for a PUK, we
don't report LockedPins properly.
2010-08-05 10:00:57 -05:00
Marcel Holtmann
1fedd096a0
Check sanity the MNC length value from the SIM card
...
In case the SIM entry is wrong or we force reading of it, nasty things
like this can happen:
ofonod[12456]: Control:> AT+CRSM=176,28589,0,0,4\r
ofonod[12456]: Control:< +CRSM: 144,0,"00FFFF"\r\n\r\nOK\r\n
*** buffer overflow detected ***: ./src/ofonod terminated
======= Backtrace: =========
/lib64/libc.so.6(__fortify_fail+0x37)[0x3e42efb417]
/lib64/libc.so.6[0x3e42ef9310]
/lib64/libc.so.6(__strncpy_chk+0x17b)[0x3e42ef85cb]
2010-06-22 17:21:03 +02:00
Denis Kenzior
f2f5810942
sim: move ServiceDiallingNumbers to ServiceNumbers
...
In line with the API documentation
2010-05-27 14:58:29 -05:00
Denis Kenzior
73bfae4f46
sim: Read EFiccid after EFphase
2010-05-19 23:48:34 -05:00
Denis Kenzior
bbd6a1d48a
sim: No need for this define
2010-05-19 23:47:41 -05:00
Daniel Wagner
b338033307
Read EF_ICCID property of SIM
...
Tested with phonesim.
2010-05-19 23:41:03 -05:00
Denis Kenzior
50264a311d
Style: Proper indentation
2010-04-15 16:49:42 -05:00
Andrzej Zaborowski
aad4d0de78
Add Sim Toolkit atom
...
- Add ofono_stk atom in stk.c
- Move envelope command from sim driver to stk driver
2010-04-15 16:49:40 -05:00
Denis Kenzior
228e1e735c
Fix: Minor style issues
2010-04-15 16:49:40 -05:00
Denis Kenzior
c63b2c9d44
Fix: Uncomplicate the logic for SIM initialization
...
If we get a sim inserted notify before we are registered, we need to
initialize the SIM once ofono_sim_register is called. The logic for
doing so is rather twisted, simplify it.
2010-04-15 16:49:40 -05:00
Andrzej Zaborowski
6dc4799d1b
Add SIM "Present" property.
2010-04-15 16:49:40 -05:00
Andrzej Zaborowski
ddfe8acf11
Drivers can notify core of SIM insertion / removal
...
Add ofono_sim_inserted_notify function to notify the core of SIM
insertion / removal.
Make every plugin generate a sim inserted event on start. For devices
with removable card, the event should be emitted after the
plugin detects such event. For devices that need to wait for SIM card
initialization, they can emit this event later.
2010-04-15 16:49:40 -05:00
Andrzej Zaborowski
22cbe98146
Extend sim-ready watch with card insert/eject
2010-04-15 16:49:40 -05:00
Andrzej Zaborowski
42ef218668
Use stkutil named constants in sim.c
2010-03-31 13:06:14 -05:00
Denis Kenzior
9390dbaf31
Refactor: Remove MobileNetworkCodeLength property
...
Replaced by MNC/MCC properties which is more intuitive for use by
external applications.
2010-03-25 10:21:37 -05:00
Denis Kenzior
a5d54581ad
Move sim manager interface definition to dbus.h
2010-03-22 15:39:13 -05:00
Pekka Pessi
9a398a1087
Fix: Check password length based on its type
...
The different password types have different length requirements, so
update is_valid_pin to validate according to the password type being
validated (PIN / PUK / NET)
2010-03-19 13:48:04 -05:00
Denis Kenzior
62007cd074
Fix: Fixup error paths in sim_op_check_cached
2010-03-16 15:45:04 -05:00
Andrzej Zaborowski
3a9cd4fc03
Use stk_envelope_type constant name in sim.c
2010-02-27 11:40:16 -06:00
Denis Kenzior
87ca1b0c8f
Fix: Don't use ofono_debug directly in the core
...
Use DBG macro which is integrated with the new debug framework.
2010-02-08 11:54:03 -06:00
Denis Kenzior
0382f64353
Refactor: Rename & Restructure cphs_support
...
- Rename to cphs_service_table to be more inline with the specification.
- Since the spec allows arbitrary length service tables, use an unsigned
char * return instead of a short.
- Use bit_field function instead of defining an enum
2010-01-12 11:27:31 -06:00
Denis Kenzior
2b231c3f84
Rename: Rename CPHS Phase enums
...
Be more consistent with the 3GPP Phase names
2010-01-12 11:23:21 -06:00
Andrzej Zaborowski
637ca18af4
Retrieve CPHS phase (if any) from SIM.
2010-01-12 10:35:51 -06:00
Denis Kenzior
45f2f9315f
Set phase to unknown until we probe it
2010-01-06 14:17:27 -06:00
Denis Kenzior
beb3e032e4
Refactor: Preserve Phase obtained from the SIM
2010-01-06 13:19:47 -06:00
Andrzej Zaborowski
b4c3e1c1cc
Index SIM cache by phase also.
2010-01-06 13:14:20 -06:00
Marcel Holtmann
144080e749
Update copyright information
2010-01-01 17:00:10 -08:00
Denis Kenzior
955e6a61ee
Style: Fix a few more occurences of if/else
...
See Linux coding style document for details
2009-12-17 21:45:39 -06:00
Denis Kenzior
0bd6739766
Style: Fixup style issues
2009-12-17 21:45:39 -06:00
Andrzej Zaborowski
da6f3e63e0
Handle EF-CBSMID contents.
2009-12-17 21:45:39 -06:00
Denis Kenzior
60118757b2
Fix: Don't crash when cached ef structure differs
2009-10-05 16:20:55 -05:00
Denis Kenzior
be55ba4ab3
Refactor: Move elementary file type checking
...
Every single EF read callback checks the file type reported out of the
SIM is what it expects. Instead this should be done in one place and
the errors reported accordingly
2009-10-02 18:25:56 -05:00
Denis Kenzior
bb746b3e9d
Fix efli being removed prematurely
2009-09-28 11:18:50 -05:00
Denis Kenzior
bbe49a1b6e
Fix whitespace
2009-09-24 10:23:37 -05:00
Denis Kenzior
5b2852d8b4
Add initial support for LockedPins property
2009-09-24 10:23:37 -05:00
Denis Kenzior
dc644108bf
Ignore EFli if the first entry is empty
2009-09-23 17:28:15 -05:00
Andrzej Zaborowski
c98e99aef2
Remove unused struct field.
2009-09-23 14:27:49 -05:00
Andrzej Zaborowski
cb19aa987f
Rename eflp_format to efli_format, semantically opposite.
2009-09-23 14:27:26 -05:00
Denis Kenzior
cfcf7e6516
Simplify: Use dbus_message_iter_get_args
2009-09-22 11:24:21 -05:00
Denis Kenzior
b8dcd905fb
Remove unused structure
2009-09-22 11:24:21 -05:00
Marcel Holtmann
5f4340f186
Fix unused variable issue from last commits
2009-09-23 10:47:29 -07:00
Denis Kenzior
17cedf0eb7
Don't try to Lock or Unlock SIM PIN2
2009-09-22 00:07:07 -05:00
Denis Kenzior
2c4c27654c
Make sure we try to lock/unlock/change only PINs
2009-09-22 00:07:07 -05:00
Denis Kenzior
5fd083f6f4
Refactor: Do not use int instead of enum
...
27.007 does not define an enumeration for SIM PIN/PUK values. This
should be handled by ofono enum instead
2009-09-22 00:07:07 -05:00
Denis Kenzior
f599036ed0
Add LockPin and UnlockPin functions
2009-09-22 00:07:06 -05:00