sysmocom
/
ofono
mirror of git://git.sysmocom.de/ofono
11
0
Fork 0
Code Issues Releases Activity
5,264 Commits 12 Branches 0 Tags 8.9 MiB
Commit Graph

1969 Commits

Author SHA1 Message Date
Aki Niemi 6ed9fe85a5 simfs: Add NULL check 2011-02-02 11:03:21 +02:00
Aki Niemi 5d0f67e786 message-waiting: Fix indentation 2011-02-02 11:03:21 +02:00
Aki Niemi 1af43cf7f0 cbs: Fix style issues 2011-02-02 11:03:21 +02:00
Aki Niemi a7f1a1583c call-volume: Fix style issue 2011-02-02 11:03:21 +02:00
Aki Niemi 9f619fd467 call-settings: Fix style issues 2011-02-02 11:03:21 +02:00
Aki Niemi 352795aba6 call-barring: Fix style issue 2011-02-02 11:03:21 +02:00
Aki Niemi ac6656b004 netreg: Fix coding style, M12 2011-02-02 11:03:21 +02:00
Aki Niemi 9be348714d call-forwarding: Remove useless curly brackets 2011-02-02 11:03:21 +02:00
Aki Niemi 8e90c3368c simutil: Add checks for NULL 2011-02-02 11:03:21 +02:00
Aki Niemi cfa179fe6b audio-settings: Fix style, use tabs to indent 2011-02-02 11:03:21 +02:00
Aki Niemi 03d00626f6 call-meter: Fix style issues 2011-02-02 11:03:10 +02:00
Lucas De Marchi 80a257098a common: implement initializer for ofono_call 2011-02-01 18:30:53 +01:00
Andrzej Zaborowski f2c73f0a52 simfs: Return from sim_fs_op_check_cached on error 2011-01-29 18:39:37 +01:00
Andrzej Zaborowski 882c0c2761 simfs: Reset op_source in simfs_read_block 
If the block is not in cache or if this is the last block of a last
op in the queue, then fs->op_source might be left with the wrong
value.
 2011-01-29 18:39:37 +01:00
Lucas De Marchi f5b1c95490 smsutil: do not allow larger file names 
If file name had anything in the name after addr-msgid, it would be
parsed as well. This is not what we want, since there could be temporary
files lying around.
 2011-01-28 20:32:09 -06:00
Denis Kenzior 971bdfbe48 smsutil: Don't bother renaming to the same name 
In sms_tx_queue_load, if the resulting file is the same (which is quite
often the case) then don't bother trying to rename it.
 2011-01-28 20:27:58 -06:00
Denis Kenzior 31a4c0025d smsutil: Fix corner case during tx queue loading 
If there are extraneous files in the directory when it is being loaded,
then the index used to rename the old file into the new file can get out
of sync with what the core expects.
 2011-01-28 20:20:56 -06:00
Denis Kenzior b1acc3c2db smsutil: simplify tx backup loading 
glib functions as a rule do not use g_try* variations.  They use
g_malloc instead, so there's no need to check for out of memory
conditions.
 2011-01-28 19:51:32 -06:00
Lucas De Marchi bc0386cb23 sms: restore pending tx messages from backup 
Based on patch from: Kristen Carlson Accardi <kristen@linux.intel.com>
 2011-01-28 16:55:31 -06:00
Lucas De Marchi f55447a39e sms: delete sent sms messages from backup 
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
 2011-01-28 16:14:41 -06:00
Lucas De Marchi 8305ddf321 sms: store pending tx pdus on disk 
Based on patch from Kristen Carlson Accardi <kristen@linux.intel.com>
 2011-01-28 16:14:12 -06:00
Pekka Pessi 579a1ebef3 message-waiting: check for NULL argument 2011-01-26 16:47:15 -06:00
Jeevaka Badrappan 12c3cf6969 voicecall: remove ofono_cug_option 2011-01-26 16:38:15 -06:00
Jeevaka Badrappan 0be9e23a90 stk: Fix issue in stk_alpha_id_set 
Fixes the crash seen with the null alpha identifier.
Also removed the icon check since the decision of whether to inform the
user of the action is dependent entirely on whether the alpha identifier
is provided by the UICC.
 2011-01-26 15:24:50 -06:00
Denis Kenzior dc3019031d gprs: Refactor gprs provisioning 2011-01-26 14:55:59 -06:00
Denis Kenzior a02387d0b5 gprs: Put back the id if context creation fails 2011-01-26 14:55:59 -06:00
Denis Kenzior 04ce2bd8cc gprs: write out MessageCenter and MessageProxy 
These values were not written out to settings
 2011-01-26 14:55:59 -06:00
Denis Kenzior 71e5278ce6 gprs-provision: Refactor provisioning 2011-01-26 14:55:58 -06:00
Jukka Saunamaki 7a5f06dd6a gprs: add gprs context provisioning 2011-01-26 14:55:58 -06:00
Jukka Saunamaki e225f56ed0 gprs-provision: add driver API sources 2011-01-26 14:55:58 -06:00
Jukka Saunamaki feee571bba ofono.h: add gprs-provision 2011-01-26 14:55:58 -06:00
Aki Niemi ba3276a8ff simutil: Add EFcsp file and service group IDs 2011-01-26 10:38:56 +01:00
Marcel Holtmann ed99980cd3 modem: Simplify the modem lockdown modification 2011-01-26 09:51:41 +01:00
Marcel Holtmann 8637e31d1d modem: Be a bit more paranoid with lock_owner reset 2011-01-26 09:48:48 +01:00
Rémi Denis-Courmont 8c88ccaad9 modem: do not allow more than one client to lock down 2011-01-26 09:46:42 +01:00
Lucas De Marchi 3ef33522e7 call-settings: use enum values 
Use the enum values defined for CLIP, CNAP, CLIR, COLP and COLR.
 2011-01-25 23:33:20 -06:00
Rafael Ignacio Zurita 4eda451c03 common: add function to validate long numbers 
Also, adapt voicecall to use the new function for outgoing calls.
 2011-01-25 14:12:24 -06:00
Jessica Nilsson f3e3937502 simutil: EF Fileid additions USIM and SIM Phonebook 
Also, adding some general fileids for building paths
 2011-01-25 14:24:29 +01:00
Jeevaka Badrappan f49f0ad0cd stk: change timeout from 10 to 3mintues 2011-01-24 16:22:33 -06:00
Marcel Holtmann 2999252d15 modem: Add feature entry for supplementary services 2011-01-23 10:17:31 +01:00
Marcel Holtmann d1ebb6f379 ussd: Use global definition of supplementary services interface 2011-01-23 10:17:05 +01:00
Marcel Holtmann bd1e6a2a3a sim: Remove double empty lines 2011-01-22 11:06:34 +01:00
Marcel Holtmann 35aa581a0d voicecall: Fix some minor style issues for voicecall properties 2011-01-21 11:25:50 +01:00
Faiyaz Baxamusa 76081700a9 sms: Break out message objects into message.[ch] 
These can be used as is by the CDMA SMS manager atom
 2011-01-20 14:58:31 -06:00
Andrzej Zaborowski 84d0a57f8a sim-auth: Add skeleton for the sim-auth atom 2011-01-20 11:16:06 -06:00
Andrzej Zaborowski 20face53bd ofono.h: Remove unneeded initialisers 
They have no effect, enum already ensures the values are unique.
 2011-01-20 11:16:05 -06:00
Denis Kenzior 8b9e4c1e18 simutil: Fix a memory leak 2011-01-20 11:16:04 -06:00
Andrzej Zaborowski 1542bf0c59 simutil: SIM applications directory decoding utils 2011-01-20 11:15:34 -06:00
Jukka Saunamaki 0ef557e766 sim: getters for mcc and mnc implementation 2011-01-20 11:04:00 -06:00
Jukka Saunamaki da535d1288 sim: store mcc and mnc separate from imsi 2011-01-20 11:03:43 -06:00
Jeevaka Badrappan c81c88e311 stk: Handle Launch Browser proactive command 2011-01-20 10:01:24 -06:00
Jeevaka Badrappan 67d1ddc22a stkutil: add check for qualifier and browser id 
Checks the valid qualifier and browser id values
applicable for launch browser proactive command
 2011-01-20 10:00:15 -06:00
Pekka Pessi a847f2ac0f gprs: Make gprs atom offline-safe 
Allow use of GPRS atom both in online and offline (post_sim) states.

The GPRS now considers the removal of the netreg atom as implicit detach
and registration change to NOT_REGISTERED.
 2011-01-20 09:58:52 -06:00
Aki Niemi 8c15a690df netreg: Deprecate the deregister method 2011-01-20 09:54:55 -06:00
Denis Kenzior f8b2ea9ebe gprs: Move packet bearer stuff into gprs.c 2011-01-20 09:49:36 -06:00
Tomasz Gregorek 33aaeb9dff gprs: mark context driver as not used when removing active context 2011-01-20 13:31:29 +01:00
Aki Niemi 9adc84ea88 core: Always return success to a no-op 
A SetProperty that doesn't actually change the Online property's state
when no change to that state is pending, should not fail. It should
always succeed regardless of the current modem state.
 2011-01-20 12:23:25 +01:00
Rémi Denis-Courmont 8ccbc9e515 gprs: Core support for packet switched bearer reporting 2011-01-20 12:09:18 +01:00
Rémi Denis-Courmont ec34d75bc7 common: Define packet switched bearers 2011-01-20 12:07:31 +01:00
Denis Kenzior fa222d810a voicecall: Handle empty EFecc properly 
When EFecc is empty we should still set the calling codes to the
default_en_list, not keep the default_en_list + default_en_list_no_sim
 2011-01-19 15:22:23 -06:00
Pekka Pessi 2c7b1348aa sms: make sms atom offline-safe 
Allow use of SMS atom both in online and offline (post_sim) states.

SMS atom now watches network registration atom and state.  Thmessages
are queued but not sent if not registered to a network.  Errors
occurring when a short message is being sent while transition from
online to offline or when network coverage is dropped are now handled
gracefully.
 2011-01-18 22:09:07 -06:00
Denis Kenzior f4ea5142ac voicecall: Update to the new API 2011-01-18 16:09:28 -06:00
Lucas De Marchi f88f81f132 call-settings: apply rule M11 of coding style 2011-01-18 16:09:27 -06:00
Lucas De Marchi b0d783c6f1 call-settings: add support for cdip 2011-01-18 16:09:27 -06:00
Lucas De Marchi 2f5afc9410 voicecall: add support for cdip 
Enable oFono to show the identification informed with CDIP.
 2011-01-18 16:09:27 -06:00
Denis Kenzior 918d6354cc simutil: Sort sim_fileid in numerical order 2011-01-18 09:49:22 -06:00
Jessica Nilsson cf96d24884 simutil: M9, M11, Minor style fixes and indentation 2011-01-18 09:45:30 -06:00
Aki Niemi de3a9c7e7c netreg: Remove default statement 2011-01-18 14:02:59 +02:00
Aki Niemi e25d40f194 netreg: Fix userdata -> user_data 
This convention has been advertized on the mailing list.
 2011-01-18 14:02:54 +02:00
Aki Niemi 52818e3951 simutil: Style fixes, M12 2011-01-18 14:02:46 +02:00
Aki Niemi cd46b6bcf3 netreg: Style fixes, M12 2011-01-18 14:02:41 +02:00
Aki Niemi ec61c75456 common: Style fixes, M12 2011-01-18 14:02:31 +02:00
Jeevaka Badrappan 2b8a358601 sim: fix issue with sizeof call 
In some compilers, sizeof the functional argument is
not returning the actual sizeof the argument.
 2011-01-17 17:05:26 +01:00
Marit Henriksen 140d092a00 src: Added enum for PDP context status. 2011-01-14 14:32:04 +01:00
Rafael Ignacio Zurita f92f0b5d47 gps: add new interface to feature map 2011-01-13 11:08:07 -06:00
Jeevaka Badrappan 355fa67742 stk: make use of ADD_ERROR_RESULT macro 2011-01-12 16:05:37 -06:00
Jeevaka Badrappan e5bd00fd80 stk: add additional info for terminal busy result 
As per the ETSI TS 102 223 specification 8.12.2, it is
mandatory to provide additional information for the
general result "ME currently unable to process command".
 2011-01-12 16:04:29 -06:00
Andrzej Zaborowski 2cec48fb1c simfs: Add cache flushing functions 2011-01-12 14:07:09 -06:00
Jeevaka Badrappan 480f7dffd9 core: M15 coding style fix 2011-01-12 08:06:58 -08:00
Jeevaka Badrappan 819fb91144 smsutil: M15 coding style fix 2011-01-12 08:06:58 -08:00
Rémi Denis-Courmont 6082339040 gprs: avoid useless loop iteration 2011-01-10 16:31:32 -08:00
Denis Kenzior a4675c50aa sim: Minor style fixes 2011-01-10 15:42:24 -06:00
Lucas De Marchi 99dd118c5b sim: query remaining pin retries 
Check the remaining pin retries after each operation that might have
changed it, i.e. locking, unlocking, reseting or changing pin.
 2011-01-10 15:38:59 -06:00
Lasse.Kunnasluoto@tieto.com 557454453d gprs: Fixing mem leak 2011-01-10 14:57:32 -06:00
Jeevaka Badrappan b9ead5e736 stk: Remove unwanted error check 
Possible return values of  __ofono_voicecall_tone_send
are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL.
 2011-01-06 10:29:24 -08:00
Marcel Holtmann 8772946cfe network: Ignore signal strength notifications if not registered 
With the fix to query the signal strength when the registration status
changes it should be now fine again to just ignore notifications about
signal strength changes when not registered.  So put this extra check
and comment back into signal strenth notification function.
 2011-01-05 21:03:52 -08:00
Marit Henriksen b7713da077 network: query signal strength 
Signal strength is set to -1 whenever registration status changes
and differs from registered or roaming. When registration status
changes again to registered or roaming, the signal strength needs to
be updated, added query towards driver to get it.
 2011-01-05 16:20:31 -08:00
Lucas De Marchi 435e20153c dbus: fix appending on dict for types other than string 
According to dbus documentation, dbus_message_iter_append_basic()
expects a "const char**" if type is string and a simple pointer for
other types. Since we a iterating an array, the value passed is already
a pointer.
 2011-01-05 16:19:09 -08:00
Denis Kenzior 0a2648c368 stkutil: Minor style fix 2011-01-05 10:36:31 -06:00
Jeevaka Badrappan b447c56457 stkutil: add missing text and icon check 
As per the ETSI TS 102 223 section 6.5.4, If the terminal
receives an icon, and either an empty or no alpha identifier/text string
is given by the UICC, than the terminal shall reject the command
with general result "Command data not understood by terminal".
 2011-01-05 10:05:44 -06:00
Jeevaka Badrappan 2411a506e3 stkutil: Allocate for empty string in text dataobj 2011-01-05 10:04:15 -06:00
Lucas De Marchi 53b5935455 call-settings: rename CalledLine* properties 
COLP and COLR are better named respectively as ConnectedLinePresentation
and ConnectedLineRestriction as stated in 27.007 sections 7.8 and 7.31.

CalledLine* name will be used in future for CDIP.
 2010-12-30 11:15:42 -06:00
Lucas De Marchi 3b58a08eaa call-settings: fix getting CNAP property 2010-12-30 11:12:31 -06:00
Denis Kenzior 0faf44ecb6 stkutil: Add missing call to va_end in parser 2010-12-30 10:56:03 -06:00
Denis Kenzior 3c0a32c102 stk: Remove unneeded assignment 2010-12-27 15:09:03 -06:00
Jeevaka Badrappan 1e5d29012b stk: fix issue in set up menu handling 2010-12-27 15:06:08 -06:00
Marcel Holtmann c7963f1c00 sms: Add debug for SMS source and destination ports 2010-12-24 10:47:39 -08:00
Denis Kenzior 66a8002d6a Revert "stkagent: Remove unneeded goto" 
This reverts commit 46e3dbe759.
 2010-12-23 18:34:53 -06:00
Denis Kenzior 46e3dbe759 stkagent: Remove unneeded goto 2010-12-23 18:31:47 -06:00
Andrzej Zaborowski c0d584d160 stk: Send the AlphaId's to agent 
Terminate session if return signature doesn't match but allow
agent to return from the call if it does match.
 2010-12-23 18:30:45 -06:00
Denis Kenzior adda129e7c modem: Fix a typo 
The modem should be offline not online
 2010-12-22 19:28:37 -06:00
Denis Kenzior 2f11dd0a5d cdma-voicecall: Minor style fixes 2010-12-22 19:09:24 -06:00
Dara Spieker-Doyle a728ff4da1 cdma-voicecall: Add CDMA MO Call Support 2010-12-22 19:01:10 -06:00
Denis Kenzior 3daf20216f modem: Implement some race-condition avoidance 2010-12-22 14:02:59 -06:00
Gustavo F. Padovan 655da893cb modem: add Lockdown property to Modem interface 
Setting Lockdown to TRUE means power down the modem and hold a lock that
only permits the lock's owner power up the modem back. When released
it restores the last state of the modem before holding the lock.
 2010-12-22 13:36:18 -06:00
Andrzej Zaborowski bb9e26f2a5 sim: Set sane number len in empty EFmsisdn records 
Valid number length range is 1 - 11 bytes, other values, such as 0xff,
could potentially crash external parsers.
 2010-12-21 14:25:09 -06:00
Gustavo F. Padovan 8bdbdc2c7d modem: restore state when resetting the modem 2010-12-17 19:12:32 -06:00
Denis Kenzior 30c19a915e call-forwarding: Properly signal changes 
For the ForwardingFlagOnSim property
 2010-12-17 17:01:59 -06:00
Denis Kenzior 183624f870 call-forwarding: Get rid of status_on_sim variable 2010-12-17 16:50:33 -06:00
Denis Kenzior 212b291e15 call-forwarding: Simplify sim_set_cf_indicator 2010-12-17 16:40:32 -06:00
Denis Kenzior 424b2f8eb9 call-forwarding: More style fixes 2010-12-17 16:30:43 -06:00
Denis Kenzior 5a9fbb912e call-forwarding: Use a flag instead of a boolean 
For storing the presence of CPHS CFF file
 2010-12-17 16:11:29 -06:00
Denis Kenzior 88d499d96e call-forwarding: Get rid of cfis_indicator 
There's no need to track this information, since if we pick a record
with cfis_indicator for something besides Voice only, then when we
set the record again, the number we set is no longer applicable to
those services.
 2010-12-17 16:08:27 -06:00
Denis Kenzior 2e1318ef34 simutil: Remove inaccurate comment 2010-12-17 16:08:27 -06:00
Denis Kenzior f0d8ae9135 call-forwarding: Minor style fixes 2010-12-17 16:08:24 -06:00
Denis Kenzior 8b848e2b7e call-forwarding: Get rid of unneeded variable 2010-12-17 12:51:18 -06:00
Jeevaka Badrappan 8f8ae1b62f call-forwarding: Read/Write cfis/cphs-cff 2010-12-17 12:23:37 -06:00
Denis Kenzior b6facb43a1 voicecall: Minor style nitpick 2010-12-17 10:52:42 -06:00
John Mathew af086533f0 voicecall: Add emergency property 2010-12-17 10:51:14 -06:00
Gustavo F. Padovan 2d35d977c5 call-settings: add CNAP support 2010-12-16 18:40:18 -06:00
Gustavo F. Padovan abd9f86aad call-settings: fix coding style 2010-12-16 18:40:18 -06:00
Denis Kenzior 28917262ed voicecall: Use cnap validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior 65776a6820 voicecall: Use clip_validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior ea643485ef voicecall: Minor style fixes 2010-12-16 18:40:17 -06:00
Gustavo F. Padovan c47dab9570 voicecall: add support for CNAP 
Enable oFono to get a info about the Calling Name.
 2010-12-16 18:40:17 -06:00
Gustavo F. Padovan 8ae1314372 common: add CNAP defines 2010-12-16 18:40:17 -06:00
Jeevaka Badrappan d06c03f099 simfs: Add unknown sim phase check 2010-12-12 04:41:27 -06:00
Jeevaka Badrappan a8c94c044f sim: fix minor issue in ofono_sim_get_phase 2010-12-12 04:37:52 -06:00
Denis Kenzior 79be5afdc1 stkutil: Allow empty strings in for Text dataobj 
Explicitly allow length = 1 (DCS) followed by zero characters.  This
seems to be explicitly allowed by the test specification (namely Get
Input 1.9.1A)
 2010-12-10 12:13:06 -06:00
Guillaume Lucas 6058c800df stk: fix issue to avoid null pointer for alpha_id 
If a SET UP CALL proactive command with no alpha identifier
occurs, the alpha_id pointer will be set to NULL. This will
generate a crash in the stkagent with dbus function. To avoid
this we use an empty string if the alpha identifier is not
present in the command.
 2010-12-10 11:18:06 -06:00
Denis Kenzior 772bee27d4 stk: No need to check for null text 
For Set up idle mode text
 2010-12-10 10:46:56 -06:00
Guillaume Lucas 778302a1e5 stkutil: fix crash cause by null text string 
According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.
 2010-12-10 10:46:56 -06:00
Denis Kenzior e74e2c3739 radio-settings: Minor style fixes for rule M13 2010-12-08 11:55:07 -06:00
Denis Kenzior e23d25c895 radio-settings: Minor style issues 2010-12-08 11:35:44 -06:00
Lucas De Marchi cefa3b14dc radio-settings: add frequency band selection props 2010-12-08 11:32:15 -06:00
Denis Kenzior 44a8b282ca simutil: fixup style according to M11 2010-12-08 09:44:39 -06:00
Yang Gu 5713d5e19f stk: Handle provide local info proactive command 2010-12-08 07:58:24 -06:00
Yang Gu f6b037661b smsutil: Make timezone an optional field 2010-12-08 07:53:30 -06:00
Yang Gu 173c6798d6 smsutil: Change the range of time zone 2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 5862e614fd Add ofono_modem_reset() 
Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.
 2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 42a90432e7 modem: only unref pending if it is a powered pending 2010-12-07 12:16:20 -06:00
Denis Kenzior 353d1548bd smsutil: Minor style fix 2010-12-07 12:16:20 -06:00
Pekka Pessi da444beb2d voicecall: fix dial result handling 
The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.

However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.

The dial result handling now guards againt returning a previously dialed
active call as result.
 2010-12-03 13:21:32 -06:00
Denis Kenzior 7c3a800267 network: Send strength as a byte, not uint16 
To be consistent with the documentation
 2010-12-03 12:14:06 -06:00
Jeevaka Badrappan ef785f9373 smsutil: Fix issue in mwi dcs decoding 2010-12-02 08:08:54 -06:00
Antti Paila 185bb79b1b gprs: Fix for gprs context conversion 2010-12-02 07:58:17 -06:00
Denis Kenzior c5a42cfabe smsutil: Fix uninitialized optional elements 
sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.
 2010-12-02 07:53:54 -06:00
Denis Kenzior ac72349017 sms: Use the right union member for DCS check 2010-12-02 07:49:49 -06:00
Guillaume Lucas 8b0307a621 stk: Add busy error for the display text command 
According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.
 2010-11-30 08:20:42 -06:00
Jeevaka Badrappan 5154d5e38d sim: be more paranoid for triggering EFest read 2010-11-29 14:57:04 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:27:15 -06:00
Lucas De Marchi 42bafa260a simutil: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:12:04 -06:00
Lucas De Marchi 7484d799c9 simfs: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:09:50 -06:00
Lucas De Marchi d77999cc59 util: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:05:16 -06:00
Lucas De Marchi d725e79682 stkutil: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:04:35 -06:00
Lucas De Marchi 8e0f9aab9e smsutil: explicitly compare pointers to NULL 
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
 2010-11-29 13:04:04 -06:00
Jeevaka Badrappan 85cbc6926e simutil: Add EFcfis and EFcphs-cff file Ids 2010-11-27 11:49:25 -06:00
Jeevaka Badrappan 364309b9db call-volume: Minor coding style fix 2010-11-26 15:23:57 -06:00
Jeevaka Badrappan 2151ac0d5c audio-settings: Remove unwanted check 2010-11-26 15:04:17 -06:00
Jeevaka Badrappan bbe283cebc call-volume: Remove extra line at EOF 2010-11-26 15:00:54 -06:00
Yang Gu c11d3e95cb network: Use bit as size instead of byte 2010-11-26 14:02:02 -06:00
Rémi Denis-Courmont e7c4442c69 core: Remove stray newlines in messages sent to log 2010-11-26 13:50:15 -06:00
Jeevaka Badrappan 1b9081567a call-volume: Fix dbus error message type 2010-11-26 13:43:29 -06:00
Denis Kenzior e773625ce5 ctm: fix minor style issues 2010-11-26 13:08:48 -06:00
Lucas De Marchi df2984a724 ctm: Add initial CTM atom implementation 2010-11-26 13:08:48 -06:00
Denis Kenzior cd281f4454 stkutil: Minor style fixes 2010-11-25 17:58:37 -06:00
Guillaume Lucas 9b690aad40 stkutil: Use sms_dcs_decode in decode_text 
This is a much more pedantic version that can be used to
retrieve the text character set.
 2010-11-25 17:57:26 -06:00
Andrzej Zaborowski 3d1a4ec239 stk: use bigger timeout in DisplayText 
When the wait for user confirmation bit is set.
 2010-11-25 16:46:33 -06:00
Jeevaka Badrappan 175ac85942 call-forwarding: skip property change data and fax 2010-11-24 15:54:46 -06:00
Lucas De Marchi b1c159e6f6 text-telephony: add new interface to feature map 2010-11-24 09:00:40 -06:00
Rémi Denis-Courmont e9d80e40ac common: remove redundant predicate 
If the first character is a plus sign, then it is not a nul, then
the string length is true anyway.
 2010-11-23 06:48:57 -06:00
Gustavo F. Padovan b79b64439f dbus: Add __ofono_error_access_denied 2010-11-23 05:06:29 -06:00
Denis Kenzior 5774e9fa53 stk: Minor style fix 2010-11-23 03:08:56 -06:00
Andrzej Zaborowski 55e1ca2e1c stk: Handle null Text field 
Add a NULL check in dbus_apply_text_attributes because in some places
(like DisplayText handler) we call it without checking and we just check
the return value once.
 2010-11-23 03:08:51 -06:00
Denis Kenzior d1de85e5a4 call-settings: Fix style issues 2010-11-22 16:32:27 -06:00
Denis Kenzior 6c2099fd8e call-settings: fix CLIR Invocation and Suppression 
According to 22.030 the *31# version is used to suppress CLIR
and #31# version is used to invoke CLIR.
 2010-11-22 16:29:46 -06:00
Denis Kenzior 80a8fd1a64 modem: Don't notify online watches the first time 
We should not notify the online watches when we enter the OFFLINE state
for the first time.  We should only do so when we go from ONLINE state
into the OFFLINE state.
 2010-11-22 09:56:22 -06:00
Denis Kenzior 60aceb3e71 modem: Miscellaneous style fixes 2010-11-22 09:54:25 -06:00
Andras Domokos d7fb7da021 modem: add modem online-offline watch 2010-11-22 09:53:41 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Jeevaka Badrappan 4988741107 simutil: coding style fixes - rule M6 2010-11-22 05:06:38 -06:00
Jeevaka Badrappan b4353d15ea simfs: coding style fixes - rule M6 2010-11-22 05:06:21 -06:00
Jeevaka Badrappan 58b3d888c0 stkutil: coding style fixes - rule M6 2010-11-22 05:05:52 -06:00
Jeevaka Badrappan e6e27406ae smsutil: coding style fixes - rule M6 2010-11-22 05:05:31 -06:00
Jeevaka Badrappan 627ec8b0c3 util: coding style fixes - rule M6 2010-11-22 05:05:07 -06:00
Marcel Holtmann d74471e4d9 modem: Fix small coding style issue 2010-11-19 11:40:31 +01:00
Jeevaka Badrappan dfa7cf7145 util: Remove extra tab 2010-11-17 10:03:26 -06:00
Denis Kenzior 5625c9728f modem: Fix up doc typo 2010-11-17 08:26:26 -06:00
Gustavo F. Padovan 8ae8deb44f Simplify ofono_modem_set_powered() logic 2010-11-15 07:39:16 -06:00
Denis Kenzior 5c9a03b480 sms: Fix up comment style and wording 2010-11-10 09:17:19 -06:00
Denis Kenzior c18e01be16 cbs: Minor style fixes 2010-11-10 09:15:51 -06:00
Andrzej Zaborowski 32e4eae814 cbs: CBS-PP download must be enabled in sst / est 2010-11-10 09:10:48 -06:00
Andrzej Zaborowski 45b944d84b sms: SMS-PP download must be enabled in sst / est 2010-11-10 09:09:55 -06:00
Andrzej Zaborowski 3083841f72 sim: Add sim_service_available() 
This is meant to query EFsst or EFust.

The function is not public api because the service constants are in
src/simutil.h.
 2010-11-10 09:09:05 -06:00
Andrzej Zaborowski 028c8c011b sms: Handle "USIM Download" SMS type. 2010-11-08 13:36:47 -06:00
Andrzej Zaborowski 65159c2f0b stk: API for SMS Point-to-Point download to UICC 
The callback returns the TP-User-Data element content of the RP-ACK or
RP-ERROR message, returned by the UICC.
 2010-11-08 13:36:23 -06:00
Pekka Pessi 32b333059b gprs: NULL-safe ofono_gprs_context_remove() 
Check for NULL in one place.
 2010-11-08 13:03:16 -06:00
Gustavo F. Padovan 24032bd526 dbus: Use OFONO_ERROR_INTERFACE define 
Instead of the legacy DBUS_GSM_ERROR_INTERFACE.  The new name is more
generic, which make more sense.
 2010-11-08 11:36:44 -06:00
Denis Kenzior d7403d521b sim: Check both EFust and EFest for FDN & BDN 
We were checking EFest only for whether BDN and FDN were enabled.
According to 31.102 Section 5.3.2 we should be checking both EFust
(availability of the service) and EFest (whether it is enabled)
 2010-11-05 09:14:32 -05:00
Denis Kenzior e613c686a6 sim: Don't read EFest if the file is not available 2010-11-05 09:14:32 -05:00
Guillaume Lucas aa2c87886f sim: use mask for check of sim file status 
It is the first bit of the sim file status who indicates if a file
is valid or not. So a mask must be used to check this.
 2010-11-05 09:14:32 -05:00
Denis Kenzior 78cac8472f smsutil: Use entire range of ref / port addresses 2010-11-04 11:09:11 -05:00
Denis Kenzior 4815d84789 sms: Call the txq_submit queued callback 2010-11-04 10:25:42 -05:00
Denis Kenzior 857e2d046f sms: Separate history from dbus flags in txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 3436c58fac sms: Refactor __ofono_sms_txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 4a2111347f sms: Add __ofono_sms_message_path_from_uuid 2010-11-04 10:25:41 -05:00
Denis Kenzior 0edb5e3645 sms: add __ofono_sms_get_next_ref 2010-11-04 10:25:41 -05:00
Denis Kenzior 8b54166523 smsutil: Remove traces of ref_offset variable 2010-11-02 15:56:30 -05:00
Denis Kenzior 2a18afa994 sms: Fix unused variable warning 2010-11-02 15:56:22 -05:00
Denis Kenzior 4c659f5e69 ofono.conf: Punch hole for SmartMessagingAgent 2010-11-02 15:08:24 -05:00
Denis Kenzior 2cc92d80e6 smsutil: Add sms_datagram_prepare 2010-11-02 14:58:21 -05:00
Denis Kenzior e29d1338b9 sms: Update to the new smsutil api 2010-11-02 14:58:21 -05:00
Denis Kenzior 57d847692c smsutil: Get rid of ref_offset in sms_text_prepare 
The reason for this parameter has ceased to exist quite a while ago.
Namely when the API allowed multiple SMS recipients.  We prepared a
single set of segments and then reset the to address and reference.  We
no longer allow multiple recipients and none of this is now needed.
 2010-11-02 14:58:21 -05:00
Denis Kenzior 348bdb7f1d sms: Don't crash when encoding fails 2010-11-02 12:15:53 -05:00
Denis Kenzior a05ebc93ab smsutil: Additional sanity checks for decode_scts 2010-11-02 12:15:53 -05:00
Denis Kenzior 9d52fd0da0 ofono.conf: Punch hole for PushNotificationAgent 2010-11-02 12:15:53 -05:00
Denis Kenzior 8f5d8280b6 sms: Minor style fix 2010-11-02 12:15:53 -05:00
Denis Kenzior f5db7564e8 sms: Left shift 8-bit ports by 16 
These are less commonly used so make them not interfere with 16 bit
ports
 2010-11-02 12:15:53 -05:00
Denis Kenzior ac731f2071 smsagent: Add smsagent implementation 
Based on the patches by Aki Niemi
 2010-11-02 12:15:53 -05:00
Mika Liljeberg d282509a9d main: add capabilities for phonet 
Phonet sockets require CAP_SYS_ADMIN and SO_BINDTODEVICE socket
option requires CAP_NET_RAW.
 2010-11-01 17:27:46 +01:00
Denis Kenzior 5c6144f359 stk: Handle Send SS in handled_notify 2010-10-28 10:37:05 -05:00
Denis Kenzior bef003059e radio-settings: Don't check for cached 
Checking for this flag does not have the desired effect, or rather it
has other side-effects (e.g. setting the property twice before
GetProperties).  oFono discourages spurious signal emission.
 2010-10-27 22:26:15 -05:00
Denis Kenzior 107f6ee731 radio-settings: Add extra newlines 
To be compliant with the coding style
 2010-10-27 22:26:15 -05:00
Mika Liljeberg a4983d99eb radio settings: add FastDormancy property 2010-10-27 22:26:15 -05:00
Johan Hedberg aed4eac9fa Fix string array memory leaks during plugin loading 2010-10-28 01:50:26 +02:00
Denis Kenzior bbe6eb6d4e gprs-context: Replace TYPE_INVALID with TYPE_ANY 2010-10-27 12:39:46 -05:00
Denis Kenzior 51aecde6cc stk: Remove ofono_stk_terminal_response_sent_notify 
Not needed for now.  We can always put this back in later if need be.
 2010-10-27 12:10:17 -05:00
Andrzej Zaborowski 77c20d8a27 stk: Handle more commands in handled_notify 2010-10-27 12:00:42 -05:00
Marcel Holtmann 99bd7d0399 gprs: Use common function for default name of default Internet context 2010-10-27 18:14:50 +02:00
Pekka Pessi de96428ca2 gprs-context: add IMS connection type 2010-10-27 16:57:57 +02:00
Marcel Holtmann 4e72af9b19 gprs: Add host route to the configured MMS proxy 2010-10-27 16:09:27 +02:00
Marcel Holtmann 534d1ccec6 gprs: Set IP address for GPRS contexts of type MMS 2010-10-27 15:25:25 +02:00
Marcel Holtmann 87cd9f57b3 gprs: Add support for exposing proxy information for MMS context 2010-10-27 15:09:33 +02:00
Marcel Holtmann c409dacbc8 gprs: Add support for selecting GPRS context drivers based on types 2010-10-27 14:43:32 +02:00
Marcel Holtmann a46fbe493e main: Enable active capability dropping 2010-10-27 14:03:13 +02:00
Marcel Holtmann 8ff5d6d6a9 gprs: Add flag to track usage of GPRS context drivers 2010-10-27 13:56:12 +02:00
Marcel Holtmann c7a5210be6 gprs: Extract GPRS context assignment into separate function 2010-10-27 11:53:37 +02:00
Marcel Holtmann b3d18d5115 gprs: Add support for setting GPRS context type 2010-10-27 11:34:54 +02:00
Marcel Holtmann 6cb86931e3 gprs: Make GPRS context type a public enum 2010-10-27 11:28:52 +02:00
Marcel Holtmann 0df5a60a0c gprs: Load stored MMS Proxy and MMSC settings 2010-10-27 00:51:51 +02:00
Marcel Holtmann 20f3a3adb2 gprs: Use better default name for context creation 2010-10-26 23:19:54 +02:00
Marcel Holtmann 768d02a881 gprs: Add support for storing MMS Proxy and MMSC settings 2010-10-26 23:14:58 +02:00
Marcel Holtmann 483663eeed gprs: Assign GPRS atom to GPRS context atom 
If the GPRS atom is not assigned to the GPRS context atom, then possible
network triggered activation crashes.
 2010-10-26 14:03:47 +02:00
Denis Kenzior d9ad66ab38 stk: Default to general beep if no tone is provided 
According to section 6.6.5 of 102.223
 2010-10-25 17:42:41 -05:00
Andrzej Zaborowski b15bcb4a40 stk: Handle the Play Tone proactive command. 2010-10-25 17:23:12 -05:00
Andrzej Zaborowski 47c3b3f52a stk: Add duration_to_msecs to reduce duplication. 2010-10-25 17:21:23 -05:00
Andrzej Zaborowski e0663bd0ed voicecall: Limit tone string length per request. 
Also change to avoid memcpying into a buffer.
 2010-10-25 17:20:17 -05:00
Denis Kenzior ee4879d196 gprs: Return busy if ops are potentially colliding 2010-10-25 16:32:49 -05:00
Denis Kenzior 180f765ebe gprs: Implement DeactivateAll() 2010-10-25 16:32:49 -05:00
Denis Kenzior 1677e19ab5 manager: Don't show modems which are not registered 2010-10-25 16:32:49 -05:00