Commit Graph

1757 Commits

Author SHA1 Message Date
Lucas De Marchi f88f81f132 call-settings: apply rule M11 of coding style 2011-01-18 16:09:27 -06:00
Lucas De Marchi b0d783c6f1 call-settings: add support for cdip 2011-01-18 16:09:27 -06:00
Lucas De Marchi 2f5afc9410 voicecall: add support for cdip
Enable oFono to show the identification informed with CDIP.
2011-01-18 16:09:27 -06:00
Denis Kenzior 918d6354cc simutil: Sort sim_fileid in numerical order 2011-01-18 09:49:22 -06:00
Jessica Nilsson cf96d24884 simutil: M9, M11, Minor style fixes and indentation 2011-01-18 09:45:30 -06:00
Aki Niemi de3a9c7e7c netreg: Remove default statement 2011-01-18 14:02:59 +02:00
Aki Niemi e25d40f194 netreg: Fix userdata -> user_data
This convention has been advertized on the mailing list.
2011-01-18 14:02:54 +02:00
Aki Niemi 52818e3951 simutil: Style fixes, M12 2011-01-18 14:02:46 +02:00
Aki Niemi cd46b6bcf3 netreg: Style fixes, M12 2011-01-18 14:02:41 +02:00
Aki Niemi ec61c75456 common: Style fixes, M12 2011-01-18 14:02:31 +02:00
Jeevaka Badrappan 2b8a358601 sim: fix issue with sizeof call
In some compilers, sizeof the functional argument is
not returning the actual sizeof the argument.
2011-01-17 17:05:26 +01:00
Marit Henriksen 140d092a00 src: Added enum for PDP context status. 2011-01-14 14:32:04 +01:00
Rafael Ignacio Zurita f92f0b5d47 gps: add new interface to feature map 2011-01-13 11:08:07 -06:00
Jeevaka Badrappan 355fa67742 stk: make use of ADD_ERROR_RESULT macro 2011-01-12 16:05:37 -06:00
Jeevaka Badrappan e5bd00fd80 stk: add additional info for terminal busy result
As per the ETSI TS 102 223 specification 8.12.2, it is
mandatory to provide additional information for the
general result "ME currently unable to process command".
2011-01-12 16:04:29 -06:00
Andrzej Zaborowski 2cec48fb1c simfs: Add cache flushing functions 2011-01-12 14:07:09 -06:00
Jeevaka Badrappan 480f7dffd9 core: M15 coding style fix 2011-01-12 08:06:58 -08:00
Jeevaka Badrappan 819fb91144 smsutil: M15 coding style fix 2011-01-12 08:06:58 -08:00
Rémi Denis-Courmont 6082339040 gprs: avoid useless loop iteration 2011-01-10 16:31:32 -08:00
Denis Kenzior a4675c50aa sim: Minor style fixes 2011-01-10 15:42:24 -06:00
Lucas De Marchi 99dd118c5b sim: query remaining pin retries
Check the remaining pin retries after each operation that might have
changed it, i.e. locking, unlocking, reseting or changing pin.
2011-01-10 15:38:59 -06:00
Lasse.Kunnasluoto@tieto.com 557454453d gprs: Fixing mem leak 2011-01-10 14:57:32 -06:00
Jeevaka Badrappan b9ead5e736 stk: Remove unwanted error check
Possible return values of  __ofono_voicecall_tone_send
are -ENOSYS, -ENOENT, -ENOMEM and -EINVAL.
2011-01-06 10:29:24 -08:00
Marcel Holtmann 8772946cfe network: Ignore signal strength notifications if not registered
With the fix to query the signal strength when the registration status
changes it should be now fine again to just ignore notifications about
signal strength changes when not registered.  So put this extra check
and comment back into signal strenth notification function.
2011-01-05 21:03:52 -08:00
Marit Henriksen b7713da077 network: query signal strength
Signal strength is set to -1 whenever registration status changes
and differs from registered or roaming. When registration status
changes again to registered or roaming, the signal strength needs to
be updated, added query towards driver to get it.
2011-01-05 16:20:31 -08:00
Lucas De Marchi 435e20153c dbus: fix appending on dict for types other than string
According to dbus documentation, dbus_message_iter_append_basic()
expects a "const char**" if type is string and a simple pointer for
other types. Since we a iterating an array, the value passed is already
a pointer.
2011-01-05 16:19:09 -08:00
Denis Kenzior 0a2648c368 stkutil: Minor style fix 2011-01-05 10:36:31 -06:00
Jeevaka Badrappan b447c56457 stkutil: add missing text and icon check
As per the ETSI TS 102 223 section 6.5.4, If the terminal
receives an icon, and either an empty or no alpha identifier/text string
is given by the UICC, than the terminal shall reject the command
with general result "Command data not understood by terminal".
2011-01-05 10:05:44 -06:00
Jeevaka Badrappan 2411a506e3 stkutil: Allocate for empty string in text dataobj 2011-01-05 10:04:15 -06:00
Lucas De Marchi 53b5935455 call-settings: rename CalledLine* properties
COLP and COLR are better named respectively as ConnectedLinePresentation
and ConnectedLineRestriction as stated in 27.007 sections 7.8 and 7.31.

CalledLine* name will be used in future for CDIP.
2010-12-30 11:15:42 -06:00
Lucas De Marchi 3b58a08eaa call-settings: fix getting CNAP property 2010-12-30 11:12:31 -06:00
Denis Kenzior 0faf44ecb6 stkutil: Add missing call to va_end in parser 2010-12-30 10:56:03 -06:00
Denis Kenzior 3c0a32c102 stk: Remove unneeded assignment 2010-12-27 15:09:03 -06:00
Jeevaka Badrappan 1e5d29012b stk: fix issue in set up menu handling 2010-12-27 15:06:08 -06:00
Marcel Holtmann c7963f1c00 sms: Add debug for SMS source and destination ports 2010-12-24 10:47:39 -08:00
Denis Kenzior 66a8002d6a Revert "stkagent: Remove unneeded goto"
This reverts commit 46e3dbe759.
2010-12-23 18:34:53 -06:00
Denis Kenzior 46e3dbe759 stkagent: Remove unneeded goto 2010-12-23 18:31:47 -06:00
Andrzej Zaborowski c0d584d160 stk: Send the AlphaId's to agent
Terminate session if return signature doesn't match but allow
agent to return from the call if it does match.
2010-12-23 18:30:45 -06:00
Denis Kenzior adda129e7c modem: Fix a typo
The modem should be offline not online
2010-12-22 19:28:37 -06:00
Denis Kenzior 2f11dd0a5d cdma-voicecall: Minor style fixes 2010-12-22 19:09:24 -06:00
Dara Spieker-Doyle a728ff4da1 cdma-voicecall: Add CDMA MO Call Support 2010-12-22 19:01:10 -06:00
Denis Kenzior 3daf20216f modem: Implement some race-condition avoidance 2010-12-22 14:02:59 -06:00
Gustavo F. Padovan 655da893cb modem: add Lockdown property to Modem interface
Setting Lockdown to TRUE means power down the modem and hold a lock that
only permits the lock's owner power up the modem back. When released
it restores the last state of the modem before holding the lock.
2010-12-22 13:36:18 -06:00
Andrzej Zaborowski bb9e26f2a5 sim: Set sane number len in empty EFmsisdn records
Valid number length range is 1 - 11 bytes, other values, such as 0xff,
could potentially crash external parsers.
2010-12-21 14:25:09 -06:00
Gustavo F. Padovan 8bdbdc2c7d modem: restore state when resetting the modem 2010-12-17 19:12:32 -06:00
Denis Kenzior 30c19a915e call-forwarding: Properly signal changes
For the ForwardingFlagOnSim property
2010-12-17 17:01:59 -06:00
Denis Kenzior 183624f870 call-forwarding: Get rid of status_on_sim variable 2010-12-17 16:50:33 -06:00
Denis Kenzior 212b291e15 call-forwarding: Simplify sim_set_cf_indicator 2010-12-17 16:40:32 -06:00
Denis Kenzior 424b2f8eb9 call-forwarding: More style fixes 2010-12-17 16:30:43 -06:00
Denis Kenzior 5a9fbb912e call-forwarding: Use a flag instead of a boolean
For storing the presence of CPHS CFF file
2010-12-17 16:11:29 -06:00
Denis Kenzior 88d499d96e call-forwarding: Get rid of cfis_indicator
There's no need to track this information, since if we pick a record
with cfis_indicator for something besides Voice only, then when we
set the record again, the number we set is no longer applicable to
those services.
2010-12-17 16:08:27 -06:00
Denis Kenzior 2e1318ef34 simutil: Remove inaccurate comment 2010-12-17 16:08:27 -06:00
Denis Kenzior f0d8ae9135 call-forwarding: Minor style fixes 2010-12-17 16:08:24 -06:00
Denis Kenzior 8b848e2b7e call-forwarding: Get rid of unneeded variable 2010-12-17 12:51:18 -06:00
Jeevaka Badrappan 8f8ae1b62f call-forwarding: Read/Write cfis/cphs-cff 2010-12-17 12:23:37 -06:00
Denis Kenzior b6facb43a1 voicecall: Minor style nitpick 2010-12-17 10:52:42 -06:00
John Mathew af086533f0 voicecall: Add emergency property 2010-12-17 10:51:14 -06:00
Gustavo F. Padovan 2d35d977c5 call-settings: add CNAP support 2010-12-16 18:40:18 -06:00
Gustavo F. Padovan abd9f86aad call-settings: fix coding style 2010-12-16 18:40:18 -06:00
Denis Kenzior 28917262ed voicecall: Use cnap validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior 65776a6820 voicecall: Use clip_validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior ea643485ef voicecall: Minor style fixes 2010-12-16 18:40:17 -06:00
Gustavo F. Padovan c47dab9570 voicecall: add support for CNAP
Enable oFono to get a info about the Calling Name.
2010-12-16 18:40:17 -06:00
Gustavo F. Padovan 8ae1314372 common: add CNAP defines 2010-12-16 18:40:17 -06:00
Jeevaka Badrappan d06c03f099 simfs: Add unknown sim phase check 2010-12-12 04:41:27 -06:00
Jeevaka Badrappan a8c94c044f sim: fix minor issue in ofono_sim_get_phase 2010-12-12 04:37:52 -06:00
Denis Kenzior 79be5afdc1 stkutil: Allow empty strings in for Text dataobj
Explicitly allow length = 1 (DCS) followed by zero characters.  This
seems to be explicitly allowed by the test specification (namely Get
Input 1.9.1A)
2010-12-10 12:13:06 -06:00
Guillaume Lucas 6058c800df stk: fix issue to avoid null pointer for alpha_id
If a SET UP CALL proactive command with no alpha identifier
occurs, the alpha_id pointer will be set to NULL. This will
generate a crash in the stkagent with dbus function. To avoid
this we use an empty string if the alpha identifier is not
present in the command.
2010-12-10 11:18:06 -06:00
Denis Kenzior 772bee27d4 stk: No need to check for null text
For Set up idle mode text
2010-12-10 10:46:56 -06:00
Guillaume Lucas 778302a1e5 stkutil: fix crash cause by null text string
According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.
2010-12-10 10:46:56 -06:00
Denis Kenzior e74e2c3739 radio-settings: Minor style fixes for rule M13 2010-12-08 11:55:07 -06:00
Denis Kenzior e23d25c895 radio-settings: Minor style issues 2010-12-08 11:35:44 -06:00
Lucas De Marchi cefa3b14dc radio-settings: add frequency band selection props 2010-12-08 11:32:15 -06:00
Denis Kenzior 44a8b282ca simutil: fixup style according to M11 2010-12-08 09:44:39 -06:00
Yang Gu 5713d5e19f stk: Handle provide local info proactive command 2010-12-08 07:58:24 -06:00
Yang Gu f6b037661b smsutil: Make timezone an optional field 2010-12-08 07:53:30 -06:00
Yang Gu 173c6798d6 smsutil: Change the range of time zone 2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 5862e614fd Add ofono_modem_reset()
Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.
2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 42a90432e7 modem: only unref pending if it is a powered pending 2010-12-07 12:16:20 -06:00
Denis Kenzior 353d1548bd smsutil: Minor style fix 2010-12-07 12:16:20 -06:00
Pekka Pessi da444beb2d voicecall: fix dial result handling
The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.

However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.

The dial result handling now guards againt returning a previously dialed
active call as result.
2010-12-03 13:21:32 -06:00
Denis Kenzior 7c3a800267 network: Send strength as a byte, not uint16
To be consistent with the documentation
2010-12-03 12:14:06 -06:00
Jeevaka Badrappan ef785f9373 smsutil: Fix issue in mwi dcs decoding 2010-12-02 08:08:54 -06:00
Antti Paila 185bb79b1b gprs: Fix for gprs context conversion 2010-12-02 07:58:17 -06:00
Denis Kenzior c5a42cfabe smsutil: Fix uninitialized optional elements
sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.
2010-12-02 07:53:54 -06:00
Denis Kenzior ac72349017 sms: Use the right union member for DCS check 2010-12-02 07:49:49 -06:00
Guillaume Lucas 8b0307a621 stk: Add busy error for the display text command
According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.
2010-11-30 08:20:42 -06:00
Jeevaka Badrappan 5154d5e38d sim: be more paranoid for triggering EFest read 2010-11-29 14:57:04 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Lucas De Marchi 42bafa260a simutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:12:04 -06:00
Lucas De Marchi 7484d799c9 simfs: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:09:50 -06:00
Lucas De Marchi d77999cc59 util: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:05:16 -06:00
Lucas De Marchi d725e79682 stkutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:04:35 -06:00
Lucas De Marchi 8e0f9aab9e smsutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:04:04 -06:00
Jeevaka Badrappan 85cbc6926e simutil: Add EFcfis and EFcphs-cff file Ids 2010-11-27 11:49:25 -06:00
Jeevaka Badrappan 364309b9db call-volume: Minor coding style fix 2010-11-26 15:23:57 -06:00
Jeevaka Badrappan 2151ac0d5c audio-settings: Remove unwanted check 2010-11-26 15:04:17 -06:00
Jeevaka Badrappan bbe283cebc call-volume: Remove extra line at EOF 2010-11-26 15:00:54 -06:00
Yang Gu c11d3e95cb network: Use bit as size instead of byte 2010-11-26 14:02:02 -06:00
Rémi Denis-Courmont e7c4442c69 core: Remove stray newlines in messages sent to log 2010-11-26 13:50:15 -06:00