Commit Graph

1757 Commits

Author SHA1 Message Date
Denis Kenzior 88d499d96e call-forwarding: Get rid of cfis_indicator
There's no need to track this information, since if we pick a record
with cfis_indicator for something besides Voice only, then when we
set the record again, the number we set is no longer applicable to
those services.
2010-12-17 16:08:27 -06:00
Denis Kenzior 2e1318ef34 simutil: Remove inaccurate comment 2010-12-17 16:08:27 -06:00
Denis Kenzior f0d8ae9135 call-forwarding: Minor style fixes 2010-12-17 16:08:24 -06:00
Denis Kenzior 8b848e2b7e call-forwarding: Get rid of unneeded variable 2010-12-17 12:51:18 -06:00
Jeevaka Badrappan 8f8ae1b62f call-forwarding: Read/Write cfis/cphs-cff 2010-12-17 12:23:37 -06:00
Denis Kenzior b6facb43a1 voicecall: Minor style nitpick 2010-12-17 10:52:42 -06:00
John Mathew af086533f0 voicecall: Add emergency property 2010-12-17 10:51:14 -06:00
Gustavo F. Padovan 2d35d977c5 call-settings: add CNAP support 2010-12-16 18:40:18 -06:00
Gustavo F. Padovan abd9f86aad call-settings: fix coding style 2010-12-16 18:40:18 -06:00
Denis Kenzior 28917262ed voicecall: Use cnap validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior 65776a6820 voicecall: Use clip_validity in get_properties 2010-12-16 18:40:18 -06:00
Denis Kenzior ea643485ef voicecall: Minor style fixes 2010-12-16 18:40:17 -06:00
Gustavo F. Padovan c47dab9570 voicecall: add support for CNAP
Enable oFono to get a info about the Calling Name.
2010-12-16 18:40:17 -06:00
Gustavo F. Padovan 8ae1314372 common: add CNAP defines 2010-12-16 18:40:17 -06:00
Jeevaka Badrappan d06c03f099 simfs: Add unknown sim phase check 2010-12-12 04:41:27 -06:00
Jeevaka Badrappan a8c94c044f sim: fix minor issue in ofono_sim_get_phase 2010-12-12 04:37:52 -06:00
Denis Kenzior 79be5afdc1 stkutil: Allow empty strings in for Text dataobj
Explicitly allow length = 1 (DCS) followed by zero characters.  This
seems to be explicitly allowed by the test specification (namely Get
Input 1.9.1A)
2010-12-10 12:13:06 -06:00
Guillaume Lucas 6058c800df stk: fix issue to avoid null pointer for alpha_id
If a SET UP CALL proactive command with no alpha identifier
occurs, the alpha_id pointer will be set to NULL. This will
generate a crash in the stkagent with dbus function. To avoid
this we use an empty string if the alpha identifier is not
present in the command.
2010-12-10 11:18:06 -06:00
Denis Kenzior 772bee27d4 stk: No need to check for null text
For Set up idle mode text
2010-12-10 10:46:56 -06:00
Guillaume Lucas 778302a1e5 stkutil: fix crash cause by null text string
According to 3GPP TS 31.124 a zero length for the text string
should be allowed. An empty string must be returned to the
user in this case.
2010-12-10 10:46:56 -06:00
Denis Kenzior e74e2c3739 radio-settings: Minor style fixes for rule M13 2010-12-08 11:55:07 -06:00
Denis Kenzior e23d25c895 radio-settings: Minor style issues 2010-12-08 11:35:44 -06:00
Lucas De Marchi cefa3b14dc radio-settings: add frequency band selection props 2010-12-08 11:32:15 -06:00
Denis Kenzior 44a8b282ca simutil: fixup style according to M11 2010-12-08 09:44:39 -06:00
Yang Gu 5713d5e19f stk: Handle provide local info proactive command 2010-12-08 07:58:24 -06:00
Yang Gu f6b037661b smsutil: Make timezone an optional field 2010-12-08 07:53:30 -06:00
Yang Gu 173c6798d6 smsutil: Change the range of time zone 2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 5862e614fd Add ofono_modem_reset()
Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.
2010-12-07 12:16:20 -06:00
Gustavo F. Padovan 42a90432e7 modem: only unref pending if it is a powered pending 2010-12-07 12:16:20 -06:00
Denis Kenzior 353d1548bd smsutil: Minor style fix 2010-12-07 12:16:20 -06:00
Pekka Pessi da444beb2d voicecall: fix dial result handling
The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.

However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.

The dial result handling now guards againt returning a previously dialed
active call as result.
2010-12-03 13:21:32 -06:00
Denis Kenzior 7c3a800267 network: Send strength as a byte, not uint16
To be consistent with the documentation
2010-12-03 12:14:06 -06:00
Jeevaka Badrappan ef785f9373 smsutil: Fix issue in mwi dcs decoding 2010-12-02 08:08:54 -06:00
Antti Paila 185bb79b1b gprs: Fix for gprs context conversion 2010-12-02 07:58:17 -06:00
Denis Kenzior c5a42cfabe smsutil: Fix uninitialized optional elements
sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.
2010-12-02 07:53:54 -06:00
Denis Kenzior ac72349017 sms: Use the right union member for DCS check 2010-12-02 07:49:49 -06:00
Guillaume Lucas 8b0307a621 stk: Add busy error for the display text command
According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.
2010-11-30 08:20:42 -06:00
Jeevaka Badrappan 5154d5e38d sim: be more paranoid for triggering EFest read 2010-11-29 14:57:04 -06:00
Lucas De Marchi b210838e87 core: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:27:15 -06:00
Lucas De Marchi 42bafa260a simutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:12:04 -06:00
Lucas De Marchi 7484d799c9 simfs: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:09:50 -06:00
Lucas De Marchi d77999cc59 util: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:05:16 -06:00
Lucas De Marchi d725e79682 stkutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:04:35 -06:00
Lucas De Marchi 8e0f9aab9e smsutil: explicitly compare pointers to NULL
This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>
2010-11-29 13:04:04 -06:00
Jeevaka Badrappan 85cbc6926e simutil: Add EFcfis and EFcphs-cff file Ids 2010-11-27 11:49:25 -06:00
Jeevaka Badrappan 364309b9db call-volume: Minor coding style fix 2010-11-26 15:23:57 -06:00
Jeevaka Badrappan 2151ac0d5c audio-settings: Remove unwanted check 2010-11-26 15:04:17 -06:00
Jeevaka Badrappan bbe283cebc call-volume: Remove extra line at EOF 2010-11-26 15:00:54 -06:00
Yang Gu c11d3e95cb network: Use bit as size instead of byte 2010-11-26 14:02:02 -06:00
Rémi Denis-Courmont e7c4442c69 core: Remove stray newlines in messages sent to log 2010-11-26 13:50:15 -06:00
Jeevaka Badrappan 1b9081567a call-volume: Fix dbus error message type 2010-11-26 13:43:29 -06:00
Denis Kenzior e773625ce5 ctm: fix minor style issues 2010-11-26 13:08:48 -06:00
Lucas De Marchi df2984a724 ctm: Add initial CTM atom implementation 2010-11-26 13:08:48 -06:00
Denis Kenzior cd281f4454 stkutil: Minor style fixes 2010-11-25 17:58:37 -06:00
Guillaume Lucas 9b690aad40 stkutil: Use sms_dcs_decode in decode_text
This is a much more pedantic version that can be used to
retrieve the text character set.
2010-11-25 17:57:26 -06:00
Andrzej Zaborowski 3d1a4ec239 stk: use bigger timeout in DisplayText
When the wait for user confirmation bit is set.
2010-11-25 16:46:33 -06:00
Jeevaka Badrappan 175ac85942 call-forwarding: skip property change data and fax 2010-11-24 15:54:46 -06:00
Lucas De Marchi b1c159e6f6 text-telephony: add new interface to feature map 2010-11-24 09:00:40 -06:00
Rémi Denis-Courmont e9d80e40ac common: remove redundant predicate
If the first character is a plus sign, then it is not a nul, then
the string length is true anyway.
2010-11-23 06:48:57 -06:00
Gustavo F. Padovan b79b64439f dbus: Add __ofono_error_access_denied 2010-11-23 05:06:29 -06:00
Denis Kenzior 5774e9fa53 stk: Minor style fix 2010-11-23 03:08:56 -06:00
Andrzej Zaborowski 55e1ca2e1c stk: Handle null Text field
Add a NULL check in dbus_apply_text_attributes because in some places
(like DisplayText handler) we call it without checking and we just check
the return value once.
2010-11-23 03:08:51 -06:00
Denis Kenzior d1de85e5a4 call-settings: Fix style issues 2010-11-22 16:32:27 -06:00
Denis Kenzior 6c2099fd8e call-settings: fix CLIR Invocation and Suppression
According to 22.030 the *31# version is used to suppress CLIR
and #31# version is used to invoke CLIR.
2010-11-22 16:29:46 -06:00
Denis Kenzior 80a8fd1a64 modem: Don't notify online watches the first time
We should not notify the online watches when we enter the OFFLINE state
for the first time.  We should only do so when we go from ONLINE state
into the OFFLINE state.
2010-11-22 09:56:22 -06:00
Denis Kenzior 60aceb3e71 modem: Miscellaneous style fixes 2010-11-22 09:54:25 -06:00
Andras Domokos d7fb7da021 modem: add modem online-offline watch 2010-11-22 09:53:41 -06:00
Jeevaka Badrappan 2d0cb92155 src: coding style fixes - rule M6 2010-11-22 05:07:52 -06:00
Jeevaka Badrappan 4988741107 simutil: coding style fixes - rule M6 2010-11-22 05:06:38 -06:00
Jeevaka Badrappan b4353d15ea simfs: coding style fixes - rule M6 2010-11-22 05:06:21 -06:00
Jeevaka Badrappan 58b3d888c0 stkutil: coding style fixes - rule M6 2010-11-22 05:05:52 -06:00
Jeevaka Badrappan e6e27406ae smsutil: coding style fixes - rule M6 2010-11-22 05:05:31 -06:00
Jeevaka Badrappan 627ec8b0c3 util: coding style fixes - rule M6 2010-11-22 05:05:07 -06:00
Marcel Holtmann d74471e4d9 modem: Fix small coding style issue 2010-11-19 11:40:31 +01:00
Jeevaka Badrappan dfa7cf7145 util: Remove extra tab 2010-11-17 10:03:26 -06:00
Denis Kenzior 5625c9728f modem: Fix up doc typo 2010-11-17 08:26:26 -06:00
Gustavo F. Padovan 8ae8deb44f Simplify ofono_modem_set_powered() logic 2010-11-15 07:39:16 -06:00
Denis Kenzior 5c9a03b480 sms: Fix up comment style and wording 2010-11-10 09:17:19 -06:00
Denis Kenzior c18e01be16 cbs: Minor style fixes 2010-11-10 09:15:51 -06:00
Andrzej Zaborowski 32e4eae814 cbs: CBS-PP download must be enabled in sst / est 2010-11-10 09:10:48 -06:00
Andrzej Zaborowski 45b944d84b sms: SMS-PP download must be enabled in sst / est 2010-11-10 09:09:55 -06:00
Andrzej Zaborowski 3083841f72 sim: Add sim_service_available()
This is meant to query EFsst or EFust.

The function is not public api because the service constants are in
src/simutil.h.
2010-11-10 09:09:05 -06:00
Andrzej Zaborowski 028c8c011b sms: Handle "USIM Download" SMS type. 2010-11-08 13:36:47 -06:00
Andrzej Zaborowski 65159c2f0b stk: API for SMS Point-to-Point download to UICC
The callback returns the TP-User-Data element content of the RP-ACK or
RP-ERROR message, returned by the UICC.
2010-11-08 13:36:23 -06:00
Pekka Pessi 32b333059b gprs: NULL-safe ofono_gprs_context_remove()
Check for NULL in one place.
2010-11-08 13:03:16 -06:00
Gustavo F. Padovan 24032bd526 dbus: Use OFONO_ERROR_INTERFACE define
Instead of the legacy DBUS_GSM_ERROR_INTERFACE.  The new name is more
generic, which make more sense.
2010-11-08 11:36:44 -06:00
Denis Kenzior d7403d521b sim: Check both EFust and EFest for FDN & BDN
We were checking EFest only for whether BDN and FDN were enabled.
According to 31.102 Section 5.3.2 we should be checking both EFust
(availability of the service) and EFest (whether it is enabled)
2010-11-05 09:14:32 -05:00
Denis Kenzior e613c686a6 sim: Don't read EFest if the file is not available 2010-11-05 09:14:32 -05:00
Guillaume Lucas aa2c87886f sim: use mask for check of sim file status
It is the first bit of the sim file status who indicates if a file
is valid or not. So a mask must be used to check this.
2010-11-05 09:14:32 -05:00
Denis Kenzior 78cac8472f smsutil: Use entire range of ref / port addresses 2010-11-04 11:09:11 -05:00
Denis Kenzior 4815d84789 sms: Call the txq_submit queued callback 2010-11-04 10:25:42 -05:00
Denis Kenzior 857e2d046f sms: Separate history from dbus flags in txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 3436c58fac sms: Refactor __ofono_sms_txq_submit 2010-11-04 10:25:42 -05:00
Denis Kenzior 4a2111347f sms: Add __ofono_sms_message_path_from_uuid 2010-11-04 10:25:41 -05:00
Denis Kenzior 0edb5e3645 sms: add __ofono_sms_get_next_ref 2010-11-04 10:25:41 -05:00
Denis Kenzior 8b54166523 smsutil: Remove traces of ref_offset variable 2010-11-02 15:56:30 -05:00
Denis Kenzior 2a18afa994 sms: Fix unused variable warning 2010-11-02 15:56:22 -05:00
Denis Kenzior 4c659f5e69 ofono.conf: Punch hole for SmartMessagingAgent 2010-11-02 15:08:24 -05:00
Denis Kenzior 2cc92d80e6 smsutil: Add sms_datagram_prepare 2010-11-02 14:58:21 -05:00
Denis Kenzior e29d1338b9 sms: Update to the new smsutil api 2010-11-02 14:58:21 -05:00
Denis Kenzior 57d847692c smsutil: Get rid of ref_offset in sms_text_prepare
The reason for this parameter has ceased to exist quite a while ago.
Namely when the API allowed multiple SMS recipients.  We prepared a
single set of segments and then reset the to address and reference.  We
no longer allow multiple recipients and none of this is now needed.
2010-11-02 14:58:21 -05:00
Denis Kenzior 348bdb7f1d sms: Don't crash when encoding fails 2010-11-02 12:15:53 -05:00
Denis Kenzior a05ebc93ab smsutil: Additional sanity checks for decode_scts 2010-11-02 12:15:53 -05:00
Denis Kenzior 9d52fd0da0 ofono.conf: Punch hole for PushNotificationAgent 2010-11-02 12:15:53 -05:00
Denis Kenzior 8f5d8280b6 sms: Minor style fix 2010-11-02 12:15:53 -05:00
Denis Kenzior f5db7564e8 sms: Left shift 8-bit ports by 16
These are less commonly used so make them not interfere with 16 bit
ports
2010-11-02 12:15:53 -05:00
Denis Kenzior ac731f2071 smsagent: Add smsagent implementation
Based on the patches by Aki Niemi
2010-11-02 12:15:53 -05:00
Mika Liljeberg d282509a9d main: add capabilities for phonet
Phonet sockets require CAP_SYS_ADMIN and SO_BINDTODEVICE socket
option requires CAP_NET_RAW.
2010-11-01 17:27:46 +01:00
Denis Kenzior 5c6144f359 stk: Handle Send SS in handled_notify 2010-10-28 10:37:05 -05:00
Denis Kenzior bef003059e radio-settings: Don't check for cached
Checking for this flag does not have the desired effect, or rather it
has other side-effects (e.g. setting the property twice before
GetProperties).  oFono discourages spurious signal emission.
2010-10-27 22:26:15 -05:00
Denis Kenzior 107f6ee731 radio-settings: Add extra newlines
To be compliant with the coding style
2010-10-27 22:26:15 -05:00
Mika Liljeberg a4983d99eb radio settings: add FastDormancy property 2010-10-27 22:26:15 -05:00
Johan Hedberg aed4eac9fa Fix string array memory leaks during plugin loading 2010-10-28 01:50:26 +02:00
Denis Kenzior bbe6eb6d4e gprs-context: Replace TYPE_INVALID with TYPE_ANY 2010-10-27 12:39:46 -05:00
Denis Kenzior 51aecde6cc stk: Remove ofono_stk_terminal_response_sent_notify
Not needed for now.  We can always put this back in later if need be.
2010-10-27 12:10:17 -05:00
Andrzej Zaborowski 77c20d8a27 stk: Handle more commands in handled_notify 2010-10-27 12:00:42 -05:00
Marcel Holtmann 99bd7d0399 gprs: Use common function for default name of default Internet context 2010-10-27 18:14:50 +02:00
Pekka Pessi de96428ca2 gprs-context: add IMS connection type 2010-10-27 16:57:57 +02:00
Marcel Holtmann 4e72af9b19 gprs: Add host route to the configured MMS proxy 2010-10-27 16:09:27 +02:00
Marcel Holtmann 534d1ccec6 gprs: Set IP address for GPRS contexts of type MMS 2010-10-27 15:25:25 +02:00
Marcel Holtmann 87cd9f57b3 gprs: Add support for exposing proxy information for MMS context 2010-10-27 15:09:33 +02:00
Marcel Holtmann c409dacbc8 gprs: Add support for selecting GPRS context drivers based on types 2010-10-27 14:43:32 +02:00
Marcel Holtmann a46fbe493e main: Enable active capability dropping 2010-10-27 14:03:13 +02:00
Marcel Holtmann 8ff5d6d6a9 gprs: Add flag to track usage of GPRS context drivers 2010-10-27 13:56:12 +02:00
Marcel Holtmann c7a5210be6 gprs: Extract GPRS context assignment into separate function 2010-10-27 11:53:37 +02:00
Marcel Holtmann b3d18d5115 gprs: Add support for setting GPRS context type 2010-10-27 11:34:54 +02:00
Marcel Holtmann 6cb86931e3 gprs: Make GPRS context type a public enum 2010-10-27 11:28:52 +02:00
Marcel Holtmann 0df5a60a0c gprs: Load stored MMS Proxy and MMSC settings 2010-10-27 00:51:51 +02:00
Marcel Holtmann 20f3a3adb2 gprs: Use better default name for context creation 2010-10-26 23:19:54 +02:00
Marcel Holtmann 768d02a881 gprs: Add support for storing MMS Proxy and MMSC settings 2010-10-26 23:14:58 +02:00
Marcel Holtmann 483663eeed gprs: Assign GPRS atom to GPRS context atom
If the GPRS atom is not assigned to the GPRS context atom, then possible
network triggered activation crashes.
2010-10-26 14:03:47 +02:00
Denis Kenzior d9ad66ab38 stk: Default to general beep if no tone is provided
According to section 6.6.5 of 102.223
2010-10-25 17:42:41 -05:00
Andrzej Zaborowski b15bcb4a40 stk: Handle the Play Tone proactive command. 2010-10-25 17:23:12 -05:00
Andrzej Zaborowski 47c3b3f52a stk: Add duration_to_msecs to reduce duplication. 2010-10-25 17:21:23 -05:00
Andrzej Zaborowski e0663bd0ed voicecall: Limit tone string length per request.
Also change to avoid memcpying into a buffer.
2010-10-25 17:20:17 -05:00
Denis Kenzior ee4879d196 gprs: Return busy if ops are potentially colliding 2010-10-25 16:32:49 -05:00
Denis Kenzior 180f765ebe gprs: Implement DeactivateAll() 2010-10-25 16:32:49 -05:00
Denis Kenzior 1677e19ab5 manager: Don't show modems which are not registered 2010-10-25 16:32:49 -05:00
Denis Kenzior cfa956596c modem: Add ofono_modem_is_registered 2010-10-25 16:32:49 -05:00
Denis Kenzior d168c35b99 gprs: Support multiple active contexts 2010-10-25 14:45:12 -05:00
Denis Kenzior dc43b56154 sim: Fix minor style issue 2010-10-25 10:39:09 -05:00
Jeevaka Badrappan 233bd42820 sim: add barred dialing support 2010-10-25 10:39:09 -05:00
Jeevaka Badrappan 06839da715 simutil: add Efbdn fileid to sim_fileid enum 2010-10-25 10:39:09 -05:00
Marcel Holtmann 3342af770a gprs: Handle failure of GPRS context atom drivers
The GRPS context atom drivers can return an error from their probe
callbacks. In that case gc->driver is NULL and will cause a crash
when trying to activate a context. So check that there is actually
a driver attached to that GPRS context.
2010-10-24 17:14:16 +02:00
Jeevaka Badrappan 9bebe654e3 simfs: Fix issue with sim_fs_op_error 2010-10-24 09:11:15 -05:00
Denis Kenzior e4a0ba26a0 stk: Nitpick some newline issues 2010-10-22 22:39:56 -05:00
Andrzej Zaborowski 6cabaec726 stk: Apply STK text attributes as html 2010-10-22 22:33:54 -05:00
Denis Kenzior d4801a306c stk: use null character instead of 0
Slightly better readability
2010-10-22 22:28:04 -05:00
Denis Kenzior 1cc2c6b1ce stk: Remove reference to positive EINVAL
Move it to the original call where it belongs
2010-10-22 22:25:20 -05:00
Andrzej Zaborowski 75ce3c7c23 stk: Handle the Send DTMF proactive command
The default_agent_notify and session_agent_notify changes below are
needed for respond_on_exit commands to be able to free up their
resources, reset alpha id, etc.  Commands other than Send DTMF that
use respond_on_exit are all associated with a agent method call and
get notified about agent exit in the callback.
2010-10-22 22:00:04 -05:00